Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support aten.remainder.Scalar and aten.remainder.Tensor #2566

Merged
merged 2 commits into from
Jan 7, 2024
Merged

feat: support aten.remainder.Scalar and aten.remainder.Tensor #2566

merged 2 commits into from
Jan 7, 2024

Conversation

zewenli98
Copy link
Collaborator

Description

Support aten.remainder.Scalar and aten.remainder.Tensor

Fixes #2564 #2565

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@github-actions github-actions bot added component: api [Python] Issues re: Python API component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths component: tests Issues re: Tests labels Dec 28, 2023
@github-actions github-actions bot requested a review from apbose December 28, 2023 17:16
@zewenli98 zewenli98 force-pushed the remainder_dynamo_converter branch from c9ff0c9 to 4407832 Compare January 2, 2024 09:02
@zewenli98 zewenli98 self-assigned this Jan 3, 2024
narendasan
narendasan approved these changes Jan 5, 2024
View reviewed changes
Copy link
Collaborator

@narendasan narendasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zewenli98 zewenli98 merged commit 8ae9eff into pytorch:main Jan 7, 2024
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@narendasan narendasan narendasan approved these changes

@apbose apbose Awaiting requested review from apbose

Assignees

@zewenli98 zewenli98

Labels
cla signed component: api [Python] Issues re: Python API component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths component: tests Issues re: Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

aten.remainder.Scalar
3 participants
@zewenli98 @narendasan @facebook-github-bot