Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Repair issue in Torch Constant Folder #2375

Merged
merged 1 commit into from
Oct 9, 2023
Merged

fix: Repair issue in Torch Constant Folder #2375

merged 1 commit into from
Oct 9, 2023

Conversation

gs-olive
Copy link
Collaborator

@gs-olive gs-olive commented Oct 9, 2023

Description

  • The latest Torch nightly changed certain operators which Inductor's constant fold utility references by name, causing errors when the constant folder is invoked
  • This PR addresses those errors accordingly by subclassing the Torch utility as needed

Fixes #2374

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • [ x ] My code follows the style guidelines of this project (You can use the linters)
  • [ x ] I have performed a self-review of my own code
  • [ x ] I have commented my code, particularly in hard-to-understand areas and hacks
  • [ x ] I have made corresponding changes to the documentation
  • [ - ] I have added tests to verify my fix or my feature
    • CI validation
  • [ x ] New and existing unit tests pass locally with my changes
  • [ x ] I have added the relevant labels to my PR in so that relevant reviewers are notified

@gs-olive
fix: Repair issue in Torch Constant Folder
430b7ca 
- The latest Torch nightly changed certain operators which Inductor's
constant fold utility references by name, causing errors when the
constant folder is invoked
- This PR addresses those errors accordingly by subclassing the Torch
utility as needed
@gs-olive gs-olive self-assigned this Oct 9, 2023
@github-actions github-actions bot added component: api [Python] Issues re: Python API component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths component: lowering Issues re: The lowering / preprocessing passes labels Oct 9, 2023
@github-actions github-actions bot requested a review from peri044 October 9, 2023 19:01
github-actions[bot]
github-actions bot approved these changes Oct 9, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

github-actions[bot]
github-actions bot approved these changes Oct 9, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

peri044
peri044 approved these changes Oct 9, 2023
View reviewed changes
Copy link
Collaborator

@peri044 peri044 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTm. Just raise a issue to track to revert this change in future if needed.

@peri044 peri044 merged commit a646e59 into main Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peri044 peri044 peri044 approved these changes

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees

@gs-olive gs-olive

Labels
cla signed component: api [Python] Issues re: Python API component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths component: lowering Issues re: The lowering / preprocessing passes priority: high
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛 [Bug] Issue in ConstantFolder where certain operators no longer exist in latest nightly
3 participants
@gs-olive @peri044 @facebook-github-bot