Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Issue in TS dimension-squeeze utility #2336

Merged
merged 1 commit into from
Sep 29, 2023

Conversation

gs-olive
Copy link
Collaborator

Description

  • Add condition to dynamic-dimension insertion for using zero dimension in place of dynamic (-1)
    • This effectively enables 2 non-contiguous dynamic dimensions. For more than two, an additional fix/overhaul of the dimension squeeze system is needed
  • Add regression test case to catch similar scenarios

Fixes #2331

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • [ x ] My code follows the style guidelines of this project (You can use the linters)
  • [ x ] I have performed a self-review of my own code
  • [ x ] I have commented my code, particularly in hard-to-understand areas and hacks
  • [ x ] I have made corresponding changes to the documentation
  • [ x ] I have added tests to verify my fix or my feature
  • [ x ] New and existing unit tests pass locally with my changes
  • [ x ] I have added the relevant labels to my PR in so that relevant reviewers are notified

Copy link
Collaborator

@narendasan narendasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gs-olive
Copy link
Collaborator Author

Validate C++ tests local

@gs-olive gs-olive merged commit 558ae7c into pytorch:main Sep 29, 2023
@gs-olive gs-olive deleted the aten_unbind_fix branch September 29, 2023 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla signed component: core Issues re: The core compiler component: tests Issues re: Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [Bug] 'aten::unbind' compile failed when with two dynamic dimension in it's shape
3 participants