Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Allow low rank inputs in Python Runtime #2282

Merged
merged 1 commit into from
Sep 27, 2023
Merged

fix: Allow low rank inputs in Python Runtime #2282

merged 1 commit into from
Sep 27, 2023

Conversation

gs-olive
Copy link
Collaborator

@gs-olive gs-olive commented Sep 1, 2023

Description

  • Enable support for 0D and 1D inputs in Python runtime
  • Remove shape checks which are faulty in cases where inputs do not have an explicit batch
  • Add regression test cases for the Python runtime

Type of change

Please delete options that are not relevant and/or add your own.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • [ x ] My code follows the style guidelines of this project (You can use the linters)
  • [ x ] I have performed a self-review of my own code
  • [ x ] I have commented my code, particularly in hard-to-understand areas and hacks
  • [ x ] I have made corresponding changes to the documentation
  • [ x ] I have added tests to verify my fix or my feature
  • [ x ] New and existing unit tests pass locally with my changes
  • [ x ] I have added the relevant labels to my PR in so that relevant reviewers are notified

@gs-olive gs-olive requested a review from narendasan September 1, 2023 19:03
@gs-olive gs-olive self-assigned this Sep 1, 2023
@github-actions github-actions bot added component: api [Python] Issues re: Python API component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths component: runtime component: tests Issues re: Tests labels Sep 1, 2023
@github-actions github-actions bot requested a review from peri044 September 1, 2023 19:03
github-actions[bot]
github-actions bot approved these changes Sep 1, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

github-actions[bot]
github-actions bot approved these changes Sep 1, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

github-actions[bot]
github-actions bot approved these changes Sep 1, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

github-actions[bot]
github-actions bot approved these changes Sep 1, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

@gs-olive gs-olive force-pushed the python_runtime_fixes branch from 9675c1b to 48157bd Compare September 1, 2023 20:46
github-actions[bot]
github-actions bot approved these changes Sep 1, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

github-actions[bot]
github-actions bot approved these changes Sep 1, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

narendasan
narendasan approved these changes Sep 26, 2023
View reviewed changes
Copy link
Collaborator

@narendasan narendasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending comment

py/torch_tensorrt/dynamo/runtime/_PythonTorchTensorRTModule.py Outdated
from typing import Any, Dict, List, Optional, Sequence, Tuple

# @manual=//deeplearning/trt/python:py_tensorrt
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this needed?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't believe so - will remove it

@gs-olive
fix: Allow low rank inputs in Python Runtime
5fb102b 
- Enable support for 0D and 1D inputs in Python runtime
- Remove shape checks which are faulty in cases where inputs do not have
an explicit batch
- Add regression test cases for the Python runtime
@gs-olive gs-olive force-pushed the python_runtime_fixes branch from 48157bd to 5fb102b Compare September 27, 2023 00:02
@gs-olive gs-olive merged commit 1033dff into main Sep 27, 2023
@gs-olive gs-olive deleted the python_runtime_fixes branch September 27, 2023 00:03
github-actions[bot]
github-actions bot approved these changes Sep 27, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

github-actions[bot]
github-actions bot approved these changes Sep 27, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@narendasan narendasan narendasan approved these changes

@github-actions github-actions[bot] github-actions[bot] approved these changes

@peri044 peri044 Awaiting requested review from peri044

Assignees

@gs-olive gs-olive

Labels
cla signed component: api [Python] Issues re: Python API component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths component: runtime component: tests Issues re: Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gs-olive @narendasan @facebook-github-bot