feat: Add ExportedProgram as an IR #2191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>
There was a problem hiding this comment.
There are some changes that do not conform to Python style guidelines:
--- /home/runner/work/TensorRT/TensorRT/py/torch_tensorrt/_compile.py 2023-08-10 23:36:35.545032+00:00
+++ /home/runner/work/TensorRT/TensorRT/py/torch_tensorrt/_compile.py 2023-08-10 23:39:45.559176+00:00
@@ -99,11 +99,13 @@
logging.Level.Warning,
"Input graph is a Torchscript module but the ir provided is default (dynamo). Please set ir=torchscript to suppress the warning. Compiling the module with ir=torchscript",
)
return _IRType.ts
elif module_is_exportable:
- raise ValueError("Input graph is an ExportedProgram which is not currently supported. Please provide torch.nn.Module or torch.fx.GraphModule as input.")
+ raise ValueError(
+ "Input graph is an ExportedProgram which is not currently supported. Please provide torch.nn.Module or torch.fx.GraphModule as input."
+ )
else:
raise ValueError("Module was provided in an unsupported format")
else:
raise ValueError("Unknown ir was requested")
There was a problem hiding this comment.
There are some changes that do not conform to Python style guidelines:
--- /home/runner/work/TensorRT/TensorRT/py/torch_tensorrt/_compile.py 2023-08-11 00:25:56.253605+00:00
+++ /home/runner/work/TensorRT/TensorRT/py/torch_tensorrt/_compile.py 2023-08-11 00:28:32.518873+00:00
@@ -101,11 +101,11 @@
)
return _IRType.ts
elif module_is_exportable:
raise ValueError(
"Input graph is an ExportedProgram which is not currently supported. Please provide torch.nn.Module or torch.fx.GraphModule as input."
- )
+ )
else:
raise ValueError("Module was provided in an unsupported format")
else:
raise ValueError("Unknown ir was requested")
There was a problem hiding this comment.
There are some changes that do not conform to Python style guidelines:
--- /home/runner/work/TensorRT/TensorRT/py/torch_tensorrt/_compile.py 2023-08-11 23:22:32.356641+00:00
+++ /home/runner/work/TensorRT/TensorRT/py/torch_tensorrt/_compile.py 2023-08-11 23:25:16.534788+00:00
@@ -101,11 +101,11 @@
)
return _IRType.ts
elif module_is_exportable:
raise ValueError(
"Input graph is an ExportedProgram which is not currently supported. Please provide torch.nn.Module or torch.fx.GraphModule as input."
- )
+ )
else:
raise ValueError("Module was provided in an unsupported format")
else:
raise ValueError("Unknown ir was requested")
Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>
gs-olive
reviewed
Aug 12, 2023
Comment on lines
+106
to
+109
| elif ir == "exported_program": | ||
| raise ValueError( | ||
| "ir=exported_program is not currently supported. Supported ir options : ts|fx|dynamo" | ||
| ) |
There was a problem hiding this comment.
Same as above for input type.
| @@ -36,6 +37,7 @@ class _IRType(Enum): | |||
| fx = 1 | |||
| dynamo = 2 | |||
| torch_compile = 3 | |||
| exported_program = 4 | |||
There was a problem hiding this comment.
Unrelated to this change, but the docstring on this Enum is not relevant to the content
Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant and/or add your own.
Checklist: