ci: Add automatic GHA job to build + push Docker Container on main
#2129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gs-olive
commented
Aug 1, 2023
.github/workflows/docker_builder.yml
Outdated
| - name: Build Docker image | ||
| env: | ||
| DOCKER_TAG: ${{ env.DOCKER_REGISTRY }}/${{ env.CONTAINER_NAME }} | ||
| run: DOCKER_BUILDKIT=1 docker build --build-arg TENSORRT_VERSION=$TENSORRT_VERSION --build-arg CUDNN_VERSION=$CUDNN_VERSION -f docker/Dockerfile --tag $DOCKER_TAG . |
There was a problem hiding this comment.
Generate TRT and CudNN versions reading from YML, set env args, use here.
gs-olive
commented
Aug 1, 2023
.github/workflows/docker_builder.yml
Outdated
| # Apply workflow only to main branch | ||
| on: | ||
| push: | ||
| branches: [ main ] |
There was a problem hiding this comment.
Add nightly branch + Docker build
gs-olive
commented
Aug 2, 2023
Comment on lines
+42
to
+45
| TRT_VERSION=$(python3 -c "import versions; versions.tensorrt_version()") | ||
| echo "TRT VERSION = ${TRT_VERSION}" | ||
| CUDNN_VERSION=$(python3 -c "import versions; versions.cudnn_version()") | ||
| echo "CUDNN VERSION = ${CUDNN_VERSION}" |
There was a problem hiding this comment.
Automatically detects default TRT and cuDNN versions from version file
- Add GHA automated job to build Docker container with latest `main` branch for Torch-TensorRT - Add concurrency control to avoid build clashes - Add environment variables to reduce code duplication, improve readability, and make the code easier to modify when versions change - Add new container registry URL to host built containers
gs-olive
commented
Aug 3, 2023
| @@ -61,6 +61,7 @@ FROM base as torch-tensorrt-builder-base | |||
| ARG ARCH="x86_64" | |||
| ARG TARGETARCH="amd64" | |||
|
|
|||
| RUN apt-get update | |||
There was a problem hiding this comment.
python3-setuptools was not being found in certain cases from the apt registry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
mainbranch for Torch-TensorRTSee here: https://github.com/pytorch/TensorRT/pkgs/container/tensorrt%2Ftorch_tensorrt_main, for a sample of what the container registry + naming looks like.
Note: It seems that previous package versions are stored in "Untagged", which is not preferable. Seeking workarounds for this.