feat: Dynamo refactor #2104

peri044 · 2023-07-12T21:32:39Z

Description

Refactor dynamo codebase

Type of change

Please delete options that are not relevant and/or add your own.

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

Checklist:

My code follows the style guidelines of this project (You can use the linters)
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas and hacks
I have made corresponding changes to the documentation
I have added tests to verify my fix or my feature
New and existing unit tests pass locally with my changes
I have added the relevant labels to my PR in so that relevant reviewers are notified

github-actions

Code conforms to C++ style guidelines

github-actions

Code conforms to C++ style guidelines

gs-olive

New organization looks good. Added a few comments. Consider adding lowering/ directory and runtime/ directory as discussed in #1826 (comment), to add lower.py and other key utilities.

py/torch_tensorrt/dynamo/backend/lowering/_fusers.py

py/torch_tensorrt/dynamo/conversion/fx2trt.py

github-actions

Code conforms to C++ style guidelines

github-actions

Code conforms to Python style guidelines

github-actions

Code conforms to C++ style guidelines

github-actions

Code conforms to C++ style guidelines

github-actions

Code conforms to Python style guidelines

github-actions

Code conforms to C++ style guidelines

github-actions

Code conforms to C++ style guidelines

github-actions

Code conforms to Python style guidelines

gs-olive

Overall the changes and testing updates look good, pending Circle CI verification. Made some comments about compilation settings.

.circleci/config.yml

py/torch_tensorrt/dynamo/compile.py

github-actions

Code conforms to C++ style guidelines

github-actions

Code conforms to Python style guidelines

github-actions

Code conforms to C++ style guidelines

github-actions

Code conforms to Python style guidelines

- Ensure imports of utilities reference new directory structure - Update the test cases to reflect the changes to `prepare_inputs.py` - Add non-breaking functionality to `_Input` class - Rename Python TRT runtime - Reword runtime detection log message

github-actions

Code conforms to C++ style guidelines

github-actions

Code conforms to Python style guidelines

Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>

github-actions

Code conforms to Python style guidelines

github-actions

Code conforms to C++ style guidelines

Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>

github-actions

Code conforms to Python style guidelines

github-actions

Code conforms to C++ style guidelines

py/torch_tensorrt/_compile.py

py/torch_tensorrt/dynamo/compile.py

Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>

github-actions

Code conforms to C++ style guidelines

github-actions

Code conforms to Python style guidelines

Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>

github-actions

Code conforms to C++ style guidelines

github-actions

Code conforms to Python style guidelines

narendasan

LGTM, @peri044 can you quickly open another PR to change the default to dynamo compile and to bump the version to 2.0.0.dev in the python package and the C++ header?

Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>

github-actions

Code conforms to C++ style guidelines

github-actions

Code conforms to Python style guidelines

py/torch_tensorrt/_compile.py

Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>

github-actions

Code conforms to Python style guidelines

github-actions

Code conforms to C++ style guidelines

peri044 requested a review from gs-olive July 12, 2023 21:32

facebook-github-bot added the cla signed label Jul 12, 2023

github-actions bot added component: api [Python] Issues re: Python API component: tests Issues re: Tests labels Jul 12, 2023

github-actions bot requested a review from narendasan July 12, 2023 21:33

github-actions bot approved these changes Jul 12, 2023

View reviewed changes

This comment was marked as resolved.

Sign in to view

gs-olive reviewed Jul 12, 2023

View reviewed changes

py/torch_tensorrt/dynamo/backend/lowering/_fusers.py Outdated Show resolved Hide resolved

py/torch_tensorrt/dynamo/conversion/fx2trt.py Outdated Show resolved Hide resolved

github-actions bot added the component: build system Issues re: Build system label Jul 12, 2023

peri044 force-pushed the dynamo_refactor branch from 05e8510 to 87d58a1 Compare July 12, 2023 22:53

github-actions bot approved these changes Jul 12, 2023

View reviewed changes

github-actions bot approved these changes Jul 13, 2023

View reviewed changes

This comment was marked as resolved.

Sign in to view

peri044 force-pushed the dynamo_refactor branch from 96b97a6 to 1db0582 Compare July 13, 2023 07:46

github-actions bot approved these changes Jul 13, 2023

View reviewed changes

This comment was marked as resolved.

Sign in to view

peri044 force-pushed the dynamo_refactor branch from c7af89a to 6c3b3f7 Compare July 13, 2023 22:29

github-actions bot approved these changes Jul 13, 2023

View reviewed changes

gs-olive reviewed Jul 14, 2023

View reviewed changes

.circleci/config.yml Show resolved Hide resolved

py/torch_tensorrt/dynamo/compile.py Outdated Show resolved Hide resolved

py/torch_tensorrt/dynamo/compile.py Outdated Show resolved Hide resolved

github-actions bot approved these changes Jul 14, 2023

View reviewed changes

peri044 force-pushed the dynamo_refactor branch from d877dd9 to 6553035 Compare July 14, 2023 09:15

github-actions bot approved these changes Jul 14, 2023

View reviewed changes

fix: Address review comments

366cd31

- Ensure imports of utilities reference new directory structure - Update the test cases to reflect the changes to `prepare_inputs.py` - Add non-breaking functionality to `_Input` class - Rename Python TRT runtime - Reword runtime detection log message

github-actions bot approved these changes Jul 18, 2023

View reviewed changes

chore: address review comments

2ae5aaa

Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>

github-actions bot approved these changes Jul 18, 2023

View reviewed changes

peri044 added 2 commits July 18, 2023 10:49

chore: Address test failures

7cc5eb7

Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>

Merge branch 'main' into dynamo_refactor

8d6c5aa

github-actions bot approved these changes Jul 18, 2023

View reviewed changes

narendasan reviewed Jul 18, 2023

View reviewed changes

py/torch_tensorrt/_compile.py Outdated Show resolved Hide resolved

narendasan reviewed Jul 18, 2023

View reviewed changes

py/torch_tensorrt/_compile.py Show resolved Hide resolved

narendasan reviewed Jul 18, 2023

View reviewed changes

py/torch_tensorrt/dynamo/compile.py Outdated Show resolved Hide resolved

chore: address review comments

2048601

Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>

github-actions bot approved these changes Jul 19, 2023

View reviewed changes

chore: Address BERT TS failure

6745b76

Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>

github-actions bot approved these changes Jul 19, 2023

View reviewed changes

narendasan approved these changes Jul 19, 2023

View reviewed changes

chore: address review comments

c267dd5

Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>

github-actions bot approved these changes Jul 19, 2023

View reviewed changes

gs-olive reviewed Jul 19, 2023

View reviewed changes

py/torch_tensorrt/_compile.py Outdated Show resolved Hide resolved

gs-olive reviewed Jul 19, 2023

View reviewed changes

py/torch_tensorrt/_compile.py Outdated Show resolved Hide resolved

chore: address review comments

b0dc251

Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>

github-actions bot approved these changes Jul 19, 2023

View reviewed changes

narendasan merged commit 0eae97f into main Jul 20, 2023

narendasan deleted the dynamo_refactor branch July 20, 2023 17:16

feat: Dynamo refactor #2104

feat: Dynamo refactor #2104

Conversation

peri044 commented Jul 12, 2023

Description

Type of change

Checklist:

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

This comment was marked as resolved.

This comment was marked as resolved.

gs-olive left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

This comment was marked as resolved.

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

This comment was marked as resolved.

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

gs-olive left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

narendasan left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment