Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Update Torch to Jul 3 Nightly #2099

Merged
merged 2 commits into from
Jul 12, 2023
Merged

chore: Update Torch to Jul 3 Nightly #2099

merged 2 commits into from
Jul 12, 2023

Conversation

gs-olive
Copy link
Collaborator

Description

  • Make necessary changes in Dynamo decompositions
  • Update WORKSPACE files

Type of change

Please delete options that are not relevant and/or add your own.

  • Version Upgrade

Checklist:

  • [ x ] My code follows the style guidelines of this project (You can use the linters)
  • [ x ] I have performed a self-review of my own code
  • [ x ] I have commented my code, particularly in hard-to-understand areas and hacks
  • [ x ] I have made corresponding changes to the documentation
  • [ x ] I have added tests to verify my fix or my feature
  • [ x ] New and existing unit tests pass locally with my changes
  • [ x ] I have added the relevant labels to my PR in so that relevant reviewers are notified

@gs-olive
chore: Update Torch to Jul 9 Nightly
a6fdec1 
- Make necessary changes in Dynamo decompositions
- Update WORKSPACE files
@gs-olive gs-olive added the component: dependencies Issues around dependencies label Jul 11, 2023
@gs-olive gs-olive requested a review from narendasan July 11, 2023 18:08
@gs-olive gs-olive self-assigned this Jul 11, 2023
@github-actions github-actions bot added component: api [Python] Issues re: Python API component: build system Issues re: Build system labels Jul 11, 2023
@gs-olive
Roll back to 0703
f7789d3 
- Update usage of `#users` in FX code
@gs-olive gs-olive force-pushed the torch_nightly_upgrade_0709 branch from 8660034 to f7789d3 Compare July 12, 2023 05:03
@gs-olive gs-olive changed the title chore: Update Torch to Jul 9 Nightly chore: Update Torch to Jul 3 Nightly Jul 12, 2023
narendasan
narendasan reviewed Jul 12, 2023
View reviewed changes
py/torch_tensorrt/dynamo/backend/lowering/_decompositions.py
@@ -27,12 +27,8 @@ def inplace_op(*args, **kwargs):
replace_inplace_op(aten.addmv_, aten.addmv)
replace_inplace_op(aten.baddbmm_, aten.baddbmm)
replace_inplace_op(aten.cumprod_, aten.cumprod)
replace_inplace_op(aten.fill_, aten.fill)
replace_inplace_op(aten.gelu_, aten.gelu)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are these being dropped for a specific reason?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, torch's default aten decompositions are now including these, which was causing failures (duplicate decomposition registrations).

narendasan
narendasan approved these changes Jul 12, 2023
View reviewed changes
Copy link
Collaborator

@narendasan narendasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gs-olive gs-olive merged commit 324766f into pytorch:main Jul 12, 2023
@gs-olive gs-olive deleted the torch_nightly_upgrade_0709 branch July 12, 2023 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@narendasan narendasan narendasan approved these changes

Assignees

@gs-olive gs-olive

Labels
cla signed component: api [Python] Issues re: Python API component: build system Issues re: Build system component: dependencies Issues around dependencies component: fx
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gs-olive @narendasan @facebook-github-bot