Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Repair import error for legacy TS testing #2091

Merged
merged 1 commit into from
Jul 11, 2023
Merged

fix: Repair import error for legacy TS testing #2091

merged 1 commit into from
Jul 11, 2023

Conversation

gs-olive
Copy link
Collaborator

@gs-olive gs-olive commented Jul 10, 2023 •
edited
Loading

Description

  • Wrap Dynamo import in version check

Fixes #2090

Type of change

Please delete options that are not relevant and/or add your own.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • [ x ] My code follows the style guidelines of this project (You can use the linters)
  • [ x ] I have performed a self-review of my own code
  • [ x ] I have commented my code, particularly in hard-to-understand areas and hacks
  • [ x ] I have made corresponding changes to the documentation
  • [ - ] I have added tests to verify my fix or my feature
    • CI Validation
  • [ x ] New and existing unit tests pass locally with my changes
  • [ x ] I have added the relevant labels to my PR in so that relevant reviewers are notified

@gs-olive gs-olive added the component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths label Jul 10, 2023
@gs-olive gs-olive self-assigned this Jul 10, 2023
@github-actions github-actions bot added the component: api [Python] Issues re: Python API label Jul 10, 2023
@github-actions github-actions bot requested a review from narendasan July 10, 2023 17:15
@gs-olive gs-olive force-pushed the legacy_import_fix branch from 6aecdaf to dfcd04a Compare July 10, 2023 19:01
@gs-olive gs-olive marked this pull request as ready for review July 10, 2023 20:09
@gs-olive gs-olive force-pushed the legacy_import_fix branch from dfcd04a to 1139d16 Compare July 10, 2023 20:27
@gs-olive
fix: Repair import error for legacy TS testing
b996c8a 
- Wrap Dynamo-dependent imports in version check
- Update import version checking to use packaging version library
@gs-olive gs-olive force-pushed the legacy_import_fix branch from 1139d16 to b996c8a Compare July 10, 2023 20:43
narendasan
narendasan approved these changes Jul 11, 2023
View reviewed changes
Copy link
Collaborator

@narendasan narendasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gs-olive gs-olive merged commit e7f4752 into pytorch:main Jul 11, 2023
@gs-olive gs-olive deleted the legacy_import_fix branch July 11, 2023 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@narendasan narendasan narendasan approved these changes

Assignees

@gs-olive gs-olive

Labels
cla signed component: api [Python] Issues re: Python API component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths component: fx
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix import error for Legacy TorchScript CI on TorchTensorRTModule
3 participants
@gs-olive @narendasan @facebook-github-bot