Change python build system to be PEP517 compatible #2056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a080d76 to
1751a7b
Compare
10ef2e2 to
869e5c6
Compare
gs-olive
requested changes
Jul 21, 2023
There was a problem hiding this comment.
Consider adding specific build commands to the README for ease of use. Additionally, the Docker build system is no longer working, with the following error shown:
/root/.pyenv/versions/3.10.12/bin/python: can't open file '/workspace/torch_tensorrt/src/py/setup.py': [Errno 2] No such file or directory
It likely needs some minor updates to ./docker/dist-build.sh
Other than that, looks good, and the following command works for me.
pip install -e . --use-pep517 --extra-index-url https://download.pytorch.org/whl/nightly/cu121 --extra-index-url https://pypi.ngc.nvidia.com/|
im going to do docs in another pr that has the full docs overhaul |
|
@apbose test this PR in NGC CI |
869e5c6 to
4b0c448
Compare
4b0c448 to
82b8948
Compare
gs-olive
approved these changes
Jul 25, 2023
82b8948 to
e6df99e
Compare
Signed-off-by: Naren Dasan <naren@narendasan.com> Signed-off-by: Naren Dasan <narens@nvidia.com> chore: Update bazel references in repo Signed-off-by: Naren Dasan <naren@narendasan.com> Signed-off-by: Naren Dasan <narens@nvidia.com> chore: Update tools in alternative WORKSPACE files Signed-off-by: Naren Dasan <naren@narendasan.com> Signed-off-by: Naren Dasan <narens@nvidia.com> chore: switch to using bazelisk in CI
Signed-off-by: Naren Dasan <naren@narendasan.com> Signed-off-by: Naren Dasan <narens@nvidia.com> test: properly disabling parameterized tests Signed-off-by: Naren Dasan <naren@narendasan.com> Signed-off-by: Naren Dasan <narens@nvidia.com> Update config.yml Fix issue with CMake build
e6df99e to
a3a0583
Compare
BREAKING CHANGE: A ton of files have been moved in order to support PEP517 standards based builds. Users are now advised to use commands such as the following: Editable installs: python -m pip install --verbose --pre -e . [if necessary add --index-url to access nightly builds of pytorch] Wheel files: python -m pip wheel --verbose --pre . [if necessary add --index-url to access nightly builds of pytorch] --config-setting="--build-option=<options you would pass to setup.py>" -w dist Alternative build processes are also supported pypa/build: python -m build --wheel --skip-dependency-check --no-isolation > Skip dependency check means you need to install py/requirements.txt first due to issues with TensorRT's python package Signed-off-by: Naren Dasan <naren@narendasan.com> Signed-off-by: Naren Dasan <narens@nvidia.com> tools: adding a pyproject.toml linter Signed-off-by: Naren Dasan <naren@narendasan.com> Signed-off-by: Naren Dasan <narens@nvidia.com> chore: update CI for new build path Signed-off-by: Naren Dasan <naren@narendasan.com> Signed-off-by: Naren Dasan <narens@nvidia.com> Adding no deps flag refactor: Formally define package contents in setup.py Signed-off-by: Naren Dasan <naren@narendasan.com> Signed-off-by: Naren Dasan <narens@nvidia.com>
a3a0583 to
9b0b8f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The python ecosystem is standardizing on PEP517(https://peps.python.org/pep-0517/) for building packages and while we were kinda compatible it was ultimately hacky. This PR adds support for PEP517 tooling formally.
Fixes #2012, #2011
Relevant for #1993
Type of change
Please delete options that are not relevant and/or add your own.
Checklist: