Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Upgrade Torch nightly to 2.1.0.dev20230605 [4 / x] #1975

Merged
merged 3 commits into from
Jun 20, 2023

Conversation

gs-olive
Copy link
Collaborator

@gs-olive gs-olive commented Jun 3, 2023

Description

  • Upgrade Torch version across the stack
  • Update setup.py dependencies
  • Switch default required C++ version to C++17, as required for new Torch distributions

Type of change

  • Dependency Version Upgrade

Checklist:

  • [ x ] My code follows the style guidelines of this project (You can use the linters)
  • [ x ] I have performed a self-review of my own code
  • [ x ] I have commented my code, particularly in hard-to-understand areas and hacks
  • [ x ] I have made corresponding changes to the documentation
  • [ x ] I have added tests to verify my fix or my feature
  • [ x ] New and existing unit tests pass locally with my changes
  • [ x ] I have added the relevant labels to my PR in so that relevant reviewers are notified

@gs-olive gs-olive added component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths Story: Export/Compile Unification Issues relating to unification of Dynamo compile/export paths Story: Dynamo Compile Improvements Issues relating to improvement of the Dynamo compile path labels Jun 3, 2023
@gs-olive gs-olive requested a review from narendasan June 3, 2023 06:20
@gs-olive gs-olive self-assigned this Jun 3, 2023
@github-actions github-actions bot added component: api [Python] Issues re: Python API component: build system Issues re: Build system component: core Issues re: The core compiler component: runtime labels Jun 3, 2023
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

@gs-olive gs-olive changed the title fix/feat: Upgrade Torch nightly, Bugfixes, Feature Additions [3 / x] fix/feat: Upgrade Torch nightly, Dynamo Bugfixes + Improvements [3 / x] Jun 3, 2023
core/runtime/TRTEngine.cpp Outdated Show resolved Hide resolved
examples/dynamo/dynamo_compile_advanced_usage.py Outdated Show resolved Hide resolved
py/torch_tensorrt/dynamo/backend/__init__.py Outdated Show resolved Hide resolved
@gs-olive gs-olive force-pushed the dynamo_compile_new_trt_features branch from 6d2a26b to 4e2f090 Compare June 8, 2023 20:00
@gs-olive gs-olive force-pushed the torch_version_upgrade_jun23_nightly branch from 4ba253f to 1bf1ff7 Compare June 8, 2023 20:08
@gs-olive gs-olive changed the base branch from dynamo_compile_new_trt_features to dynamo_backend_options June 8, 2023 20:08
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

@gs-olive gs-olive changed the title fix/feat: Upgrade Torch nightly, Dynamo Bugfixes + Improvements [3 / x] chore: Upgrade Torch nightly [6 / x] Jun 8, 2023
@gs-olive gs-olive removed component: core Issues re: The core compiler component: runtime component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths Story: Export/Compile Unification Issues relating to unification of Dynamo compile/export paths Story: Dynamo Compile Improvements Issues relating to improvement of the Dynamo compile path labels Jun 8, 2023
@gs-olive gs-olive changed the title chore: Upgrade Torch nightly [6 / x] chore: Upgrade Torch nightly to 2.1.0.dev20230607 [6 / x] Jun 8, 2023
@gs-olive gs-olive force-pushed the dynamo_backend_options branch from 849ce42 to ff5707d Compare June 8, 2023 23:30
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

@gs-olive gs-olive requested a review from narendasan June 12, 2023 17:45
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

@gs-olive gs-olive force-pushed the dynamo_backend_options branch from ff5707d to 24eda3f Compare June 14, 2023 00:34
@gs-olive gs-olive force-pushed the torch_version_upgrade_jun23_nightly branch from 15deca8 to 1735088 Compare June 14, 2023 00:35
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

@gs-olive gs-olive changed the title chore: Upgrade Torch nightly to 2.1.0.dev20230605 [6 / x] chore: Upgrade Torch nightly to 2.1.0.dev20230605 [4 / x] Jun 14, 2023
@gs-olive gs-olive force-pushed the dynamo_backend_options branch from 24eda3f to 208b40f Compare June 20, 2023 18:34
@gs-olive gs-olive force-pushed the torch_version_upgrade_jun23_nightly branch from 1735088 to 0408543 Compare June 20, 2023 18:35
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

@gs-olive gs-olive force-pushed the dynamo_backend_options branch from 208b40f to 2161370 Compare June 20, 2023 19:35
@gs-olive gs-olive force-pushed the torch_version_upgrade_jun23_nightly branch from 0408543 to d0c39f3 Compare June 20, 2023 19:37
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

- Upgrade Torch version across the stack
- Update `setup.py` dependencies
- Switch default required C++ version to C++17, as required for new Torch
distributions
@gs-olive gs-olive force-pushed the torch_version_upgrade_jun23_nightly branch from d0c39f3 to 3751e32 Compare June 20, 2023 19:53
@gs-olive gs-olive changed the base branch from dynamo_backend_options to main June 20, 2023 19:53
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

@gs-olive gs-olive merged commit cae6b7c into main Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants