Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add new TRT 8.6 features to Dynamo compile [3 / x] #1973

Merged
merged 1 commit into from
Jun 13, 2023
Merged

fix: Add new TRT 8.6 features to Dynamo compile [3 / x] #1973

merged 1 commit into from
Jun 13, 2023

Conversation

gs-olive
Copy link
Collaborator

@gs-olive gs-olive commented Jun 2, 2023 •
edited
Loading

Description

New Options in this PR:

  • max_aux_streams
  • version_compatible
  • optimization_level
  • use_experimental_rt

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • [ x ] My code follows the style guidelines of this project (You can use the linters)
  • [ x ] I have performed a self-review of my own code
  • [ x ] I have commented my code, particularly in hard-to-understand areas and hacks
  • [ x ] I have made corresponding changes to the documentation
  • [ x ] I have added tests to verify my fix or my feature
  • [ x ] New and existing unit tests pass locally with my changes
  • [ x ] I have added the relevant labels to my PR in so that relevant reviewers are notified

@gs-olive gs-olive added component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths Story: Export/Compile Unification Issues relating to unification of Dynamo compile/export paths Story: Dynamo Compile Improvements Issues relating to improvement of the Dynamo compile path labels Jun 2, 2023
@gs-olive gs-olive requested a review from narendasan June 2, 2023 20:53
@gs-olive gs-olive self-assigned this Jun 2, 2023
@github-actions github-actions bot added the component: api [Python] Issues re: Python API label Jun 2, 2023
github-actions[bot]
github-actions bot approved these changes Jun 2, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

github-actions[bot]
github-actions bot approved these changes Jun 2, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

github-actions[bot]
github-actions bot approved these changes Jun 2, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

github-actions[bot]
github-actions bot approved these changes Jun 2, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

narendasan
narendasan reviewed Jun 7, 2023
View reviewed changes
py/torch_tensorrt/dynamo/backend/__init__.py
max_aux_streams=MAX_AUX_STREAMS,
version_compatible=VERSION_COMPATIBLE,
optimization_level=OPTIMIZATION_LEVEL,
use_experimental_rt=USE_EXPERIMENTAL_RT,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we are adding the experimental runtime, we should move those changes into a new PR which also moves the RT into dynamo and have that PR depend on this

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has now been refactored into the new PR

@gs-olive gs-olive force-pushed the dynamo_compile_new_trt_features branch from 6d2a26b to 4e2f090 Compare June 8, 2023 20:00
@gs-olive gs-olive changed the base branch from dynamo_torch_compile_examples to dynamo_compile_trt_module_next June 8, 2023 20:01
github-actions[bot]
github-actions bot approved these changes Jun 8, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

github-actions[bot]
github-actions bot approved these changes Jun 8, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

@gs-olive gs-olive changed the title fix: Add new TRT 8.6 features to Dynamo compile [2 / x] fix: Add new TRT 8.6 features to Dynamo compile [3 / x] Jun 8, 2023
@gs-olive gs-olive requested a review from narendasan June 8, 2023 20:02
github-actions[bot]
github-actions bot approved these changes Jun 8, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

github-actions[bot]
github-actions bot approved these changes Jun 8, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

@gs-olive gs-olive force-pushed the dynamo_compile_trt_module_next branch 3 times, most recently from 76a85d9 to 08e9d5a Compare June 8, 2023 22:05
@gs-olive
fix: Add support for TRT 8.6 arguments
93eee96 
- Add support for new TRT 8.6 utilities, including auxiliary streams,
version compatibility, and optimization levels
- Improve documentation of features and version checking for TRT feature
compatibility
@gs-olive gs-olive force-pushed the dynamo_compile_new_trt_features branch from 4e2f090 to 93eee96 Compare June 8, 2023 23:28
github-actions[bot]
github-actions bot approved these changes Jun 8, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

github-actions[bot]
github-actions bot approved these changes Jun 8, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

narendasan
narendasan approved these changes Jun 13, 2023
View reviewed changes
Copy link
Collaborator

@narendasan narendasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@narendasan narendasan merged commit 117a98d into dynamo_compile_trt_module_next Jun 13, 2023
@narendasan narendasan deleted the dynamo_compile_new_trt_features branch June 13, 2023 21:15
gs-olive added a commit that referenced this pull request Jun 14, 2023
@gs-olive
fix: Add new TRT 8.6 features to Dynamo compile [3 / x] (#1973)
d369fa4
gs-olive added a commit that referenced this pull request Jun 21, 2023
@gs-olive
fix: Add new TRT 8.6 features to Dynamo compile [3 / x] (#1973)
e9ec251
gs-olive added a commit that referenced this pull request Jun 28, 2023
@gs-olive
fix: Add new TRT 8.6 features to Dynamo compile [3 / x] (#1973)
487ba93
gs-olive added a commit that referenced this pull request Jun 28, 2023
@gs-olive
fix: Add new TRT 8.6 features to Dynamo compile [3 / x] (#1973)
49cd3a6
gs-olive added a commit that referenced this pull request Jun 29, 2023
@gs-olive
fix: Add new TRT 8.6 features to Dynamo compile [3 / x] (#1973)
e2594b6
gs-olive added a commit that referenced this pull request Jul 6, 2023
@gs-olive
fix: Add new TRT 8.6 features to Dynamo compile [3 / x] (#1973)
f2f40a2
gs-olive added a commit that referenced this pull request Jul 7, 2023
@gs-olive
fix: Add new TRT 8.6 features to Dynamo compile [3 / x] (#1973)
1c8d93a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@narendasan narendasan narendasan approved these changes

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees

@gs-olive gs-olive

Labels
cla signed component: api [Python] Issues re: Python API component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths Story: Dynamo Compile Improvements Issues relating to improvement of the Dynamo compile path Story: Export/Compile Unification Issues relating to unification of Dynamo compile/export paths
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gs-olive @narendasan @facebook-github-bot