Reorg docs and fix css for sphix-gallery examples #1967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
33e63e0 to
e3bb744
Compare
gs-olive
reviewed
Jun 1, 2023
There was a problem hiding this comment.
The changes improve the organization and look of the Tutorials greatly. I wonder if the thumbnails could be adapted to include some sort of download/other data instead of linking to the same hyperlinked pages as above. See the bottom of this scikit-learn examples page, for instance.
examples/dynamo/README.rst
Outdated
| - `dynamo_compile_resnet_example.py <./dynamo_compile_resnet_example.html>`_: Example showcasing compilation of ResNet model | ||
| - `dynamo_compile_transformers_example.py <./dynamo_compile_transformers_example.html>`_: Example showcasing compilation of transformer-based model | ||
| - `dynamo_compile_advanced_usage.py <./dynamo_compile_advanced_usage.html>`_: Advanced usage including making a custom backend to use directly with the `torch.compile` API | ||
| * :ref:`dynamo_compile_resnet`: Compiling a ResNet model using the Dyanmo Compile Frontend for ``torch_tensorrt.compile`` |
There was a problem hiding this comment.
Minor typo (replace "Dyanmo" with "Dynamo"). Also should torch_tensorrt.compile be torch.compile? For example:
Compiling a ResNet model using the Dynamo Compile Frontend for
torch.compile
There was a problem hiding this comment.
The example uses torch_tensorrt.compile right?
| - `dynamo_compile_transformers_example.py <./dynamo_compile_transformers_example.html>`_: Example showcasing compilation of transformer-based model | ||
| - `dynamo_compile_advanced_usage.py <./dynamo_compile_advanced_usage.html>`_: Advanced usage including making a custom backend to use directly with the `torch.compile` API | ||
| * :ref:`dynamo_compile_resnet`: Compiling a ResNet model using the Dyanmo Compile Frontend for ``torch_tensorrt.compile`` | ||
| * :ref:`torch_compile_transformer`: Compiling a Transformer model using ``torch.compile`` |
There was a problem hiding this comment.
Since the transformers script is nearly the same as the Resnet script, except for the model, this could instead be:
Compiling a Transformer model using the Dynamo Compile Frontend for
torch.compile
There was a problem hiding this comment.
Id like for the Transformer script to use the torch.compile interface
| ========================= | ||
| .. _dynamo_compile_resnet: | ||
|
|
||
| Compiling ResNet using the Torch-TensorRT Dyanmo Frontend |
There was a problem hiding this comment.
See comment in examples/dynamo/README.rst
| ========================= | ||
| .. _torch_compile_transformer: | ||
|
|
||
| Compiling a Transformer using torch.compile and TensorRT |
There was a problem hiding this comment.
See comment in examples/dynamo/README.rst
c10c4ec to
0f712bd
Compare
3a4840f to
966d9fc
Compare
d333291 to
9588d68
Compare
ace988f to
764a469
Compare
f5af0a1 to
9c026a6
Compare
1410206 to
94a7942
Compare
94a7942 to
7e5f96c
Compare
966d9fc to
2684dd9
Compare
407c299 to
c64566a
Compare
render properly Signed-off-by: Naren Dasan <naren@narendasan.com> Signed-off-by: Naren Dasan <narens@nvidia.com>
Signed-off-by: Naren Dasan <naren@narendasan.com> Signed-off-by: Naren Dasan <narens@nvidia.com>
2684dd9 to
ec35106
Compare
gs-olive
reviewed
Jul 25, 2023
| - `dynamo_compile_resnet_example.py <./dynamo_compile_resnet_example.html>`_: Example showcasing compilation of ResNet model | ||
| - `dynamo_compile_transformers_example.py <./dynamo_compile_transformers_example.html>`_: Example showcasing compilation of transformer-based model | ||
| - `dynamo_compile_advanced_usage.py <./dynamo_compile_advanced_usage.html>`_: Advanced usage including making a custom backend to use directly with the `torch.compile` API | ||
| * :ref:`dynamo_compile_resnet`: Compiling a ResNet model using the Dynamo Compile Frontend for ``torch_tensorrt.compile`` |
There was a problem hiding this comment.
Needs rename, Dynamo Compile now means something else in the torch_tensorrt context
gs-olive
pushed a commit
that referenced
this pull request
Jul 25, 2023
Signed-off-by: Naren Dasan <naren@narendasan.com> Signed-off-by: Naren Dasan <narens@nvidia.com>
gs-olive
pushed a commit
that referenced
this pull request
Aug 1, 2023
Signed-off-by: Naren Dasan <naren@narendasan.com> Signed-off-by: Naren Dasan <narens@nvidia.com>
gs-olive
pushed a commit
that referenced
this pull request
Aug 2, 2023
Signed-off-by: Naren Dasan <naren@narendasan.com> Signed-off-by: Naren Dasan <narens@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reorgs some files and fixes the CSS for the gallery
Fixes # (issue)
Type of change
Please delete options that are not relevant and/or add your own.
Checklist: