feat: Refactor FX APIs under dynamo namespace for parity with TS APIs #1807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add backend adapted from previous `fx2trt_compiler` provided by Dynamo - Currently, the TRTSplitter needs work to fully support the `aten` path - Additionally, the existing `aten` pass was reworked to exclude the `torch._dynamo.export` call, which may be necessary here
Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>
Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>
…dynamo namespace Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>
7 tasks
Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>
|
@peri044 only copy over the files you made changes to to the new directory. You can just import the rest from .fx |
Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
- Update implementation to use Dynamo partition functionality - Update implementation to use Dynamo decompositions to replace inplace operators - Name backends using standard names - Add documentation, print statements, and helper functions to the code
Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>
Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>
Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>
Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>
Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>
7b67780 to
fb41cf7
Compare
|
@gs-olive is there anything blocking this merge? |
narendasan
reviewed
May 2, 2023
gs-olive
added a commit
that referenced
this pull request
May 3, 2023
…#1807) Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com> Co-authored-by: gs-olive <113141689+gs-olive@users.noreply.github.com>
gs-olive
added a commit
that referenced
this pull request
May 4, 2023
…#1807) Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com> Co-authored-by: gs-olive <113141689+gs-olive@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant and/or add your own.
Checklist: