Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding converter aten::chunk in torchscript #1802

Merged
merged 7 commits into from
Jun 2, 2023

Conversation

apbose
Copy link
Collaborator

@apbose apbose commented Apr 3, 2023

Description

Adding converrter for aten::chunk
WIP for dynamic shape

Fixes #1801

Type of change

Please delete options that are not relevant and/or add your own.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@github-actions github-actions bot added component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: core Issues re: The core compiler component: tests Issues re: Tests labels Apr 3, 2023
@github-actions github-actions bot requested a review from narendasan April 3, 2023 17:55
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some changes that do not conform to C++ style guidelines:

diff --git a/home/runner/work/TensorRT/TensorRT/tests/core/conversion/converters/test_chunk.cpp b/tmp/changes.txt
index bd6b7ce..60e4f39 100644
--- a/home/runner/work/TensorRT/TensorRT/tests/core/conversion/converters/test_chunk.cpp
+++ b/tmp/changes.txt
@@ -18,7 +18,7 @@ TEST(Converters, ATenChunkConvertsCorrectly) {

  torch::jit::parseIR(graph, g.get());

-  auto in = at::randint(1, 10, {1,100}, {at::kCUDA});
+  auto in = at::randint(1, 10, {1, 100}, {at::kCUDA});

  auto jit_in = at::clone(in);
  auto params = torch_tensorrt::core::ir::get_static_params(g->inputs(), {});
ERROR: Some files do not conform to style guidelines

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

@apbose apbose changed the title Adding converter for chunk in torchscript Adding converter aten::chunk in torchscript Apr 3, 2023
@apbose apbose removed the request for review from narendasan April 3, 2023 22:56
@apbose apbose added the WIP Work is in progress, pull request should not be merged yet label Apr 3, 2023
@github-actions github-actions bot requested a review from narendasan April 3, 2023 22:57
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

@apbose apbose removed the request for review from narendasan April 4, 2023 00:19
@apbose apbose removed the WIP Work is in progress, pull request should not be merged yet label Apr 21, 2023
Copy link
Collaborator

@narendasan narendasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Do we need to add the new file to the CMakeLists.txt?

@apbose apbose force-pushed the bose_ts_converters_chunk branch from c4bc432 to a15e87d Compare June 2, 2023 19:16
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

@apbose apbose force-pushed the bose_ts_converters_chunk branch from a15e87d to 19706d3 Compare June 2, 2023 19:17
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

@narendasan narendasan merged commit 5b156dc into main Jun 2, 2023
@narendasan narendasan deleted the bose_ts_converters_chunk branch June 2, 2023 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla signed component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: core Issues re: The core compiler component: tests Issues re: Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨[Converter] Implement aten::chunk in FX and torchscript
3 participants