Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing aten::slice invalid schema and implementing aten::list evaluator #1695

Merged
merged 6 commits into from
Jun 2, 2023
Merged

Fixing aten::slice invalid schema and implementing aten::list evaluator #1695

merged 6 commits into from
Jun 2, 2023

Conversation

apbose
Copy link
Collaborator

@apbose apbose commented Feb 22, 2023 •
edited by narendasan
Loading

Description

This PR addresses the issue #1678

Fixes #1678

-aten::slice schema is fixed since it gets invalid type
-aten::list is included in the evaluators
-PR 1691 is included for fixing prim::Loop fallback issue

Please delete options that are not relevant and/or add your own.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@github-actions github-actions bot added component: conversion Issues re: Conversion stage component: core Issues re: The core compiler component: evaluators Issues re: Specific op evaluators component: partitioning labels Feb 22, 2023
@github-actions github-actions bot requested a review from bowang007 February 22, 2023 14:14
github-actions[bot]
github-actions bot approved these changes Feb 22, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

@apbose apbose self-assigned this Feb 22, 2023
github-actions[bot]
github-actions bot approved these changes Feb 22, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

@apbose apbose changed the title Monai segresnet Fixing aten::slice invalid schema and implementing aten::list evaluator Feb 22, 2023
@narendasan
Copy link
Collaborator

@apbose we need tests for the new evaluator

@github-actions github-actions bot added the component: tests Issues re: Tests label Mar 20, 2023
github-actions[bot]
github-actions bot approved these changes Mar 20, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

github-actions[bot]
github-actions bot approved these changes Mar 20, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

@apbose apbose force-pushed the monai_segresnet branch from a9fde87 to ce17b3d Compare May 19, 2023 01:19
github-actions[bot]
github-actions bot approved these changes May 19, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

github-actions[bot]
github-actions bot approved these changes May 19, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

github-actions[bot]
github-actions bot approved these changes May 19, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

github-actions[bot]
github-actions bot approved these changes May 19, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

github-actions[bot]
github-actions bot approved these changes May 20, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

github-actions[bot]
github-actions bot approved these changes May 20, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

github-actions[bot]
github-actions bot approved these changes May 22, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

github-actions[bot]
github-actions bot approved these changes May 22, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

narendasan
narendasan approved these changes Jun 2, 2023
View reviewed changes
Copy link
Collaborator

@narendasan narendasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@narendasan narendasan merged commit 4494699 into main Jun 2, 2023
@narendasan narendasan deleted the monai_segresnet branch June 2, 2023 19:02
narendasan pushed a commit that referenced this pull request Jun 2, 2023
@apbose @narendasan
Fixing aten::slice invalid schema and implementing aten::list evaluat…
faa2cff 
…or (#1695)
narendasan pushed a commit that referenced this pull request Jun 2, 2023
@apbose @narendasan
Fixing aten::slice invalid schema and implementing aten::list evaluat…
0688e1b 
…or (#1695)
narendasan pushed a commit that referenced this pull request Jun 3, 2023
@apbose @narendasan
Fixing aten::slice invalid schema and implementing aten::list evaluat…
0d150ba 
…or (#1695)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@narendasan narendasan narendasan approved these changes

@github-actions github-actions[bot] github-actions[bot] approved these changes

@bowang007 bowang007 Awaiting requested review from bowang007

Assignees

@apbose apbose

Labels
cla signed component: conversion Issues re: Conversion stage component: core Issues re: The core compiler component: evaluators Issues re: Specific op evaluators component: partitioning component: tests Issues re: Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛Issue with brats_mri_segmentation bundle Torch_Tensorrt converting
3 participants
@apbose @narendasan @facebook-github-bot