Convolution cast #1609
Merged
Convolution cast #1609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>
Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>
Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>
There was a problem hiding this comment.
There are some changes that do not conform to C++ style guidelines:
diff --git a/home/runner/work/TensorRT/TensorRT/core/conversion/converters/impl/conv_deconv.cpp b/tmp/changes.txt
index a66dc56..5a8efff 100644
--- a/home/runner/work/TensorRT/TensorRT/core/conversion/converters/impl/conv_deconv.cpp
+++ b/tmp/changes.txt
@@ -15,8 +15,8 @@ bool add_conv_deconv(ConversionCtx* ctx, const torch::jit::Node* n, args& args)
auto in = args[0].ITensor();
if (in->getType() == nvinfer1::DataType::kINT32) {
LOG_DEBUG(
- "Found type " << in->getType() << " in aten::convolution, casting to "
- << nvinfer1::DataType::kFLOAT << " for compatibility.");
+ "Found type " << in->getType() << " in aten::convolution, casting to " << nvinfer1::DataType::kFLOAT
+ << " for compatibility.");
in = castITensor(ctx, in, nvinfer1::DataType::kFLOAT);
}
// Conv /deconv parameters
ERROR: Some files do not conform to style guidelines|
@apbose can you set up precommit to auto lint your code when you commit? |
narendasan
reviewed
Jan 23, 2023
| @@ -13,7 +13,12 @@ namespace { | |||
| bool add_conv_deconv(ConversionCtx* ctx, const torch::jit::Node* n, args& args) { | |||
| // Input to conv/deconv | |||
| auto in = args[0].ITensor(); | |||
|
|
|||
| if (in->getType() == nvinfer1::DataType::kINT32) { | |||
| LOG_DEBUG( | |||
chore: Add FX core test
chore: Update dockerfile
Signed-off-by: Torch-TensorRT Github Bot <torch-tensorrt.github.bot@nvidia.com>
Signed-off-by: Torch-TensorRT Github Bot <torch-tensorrt.github.bot@nvidia.com>
Signed-off-by: Torch-TensorRT Github Bot <torch-tensorrt.github.bot@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cast the input to the convolution layer input to float since Iconvolution layer does not support INT32 layers as it is an index type. Fix for issue - 1573
Checklist: