Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Change equals-check from reference to value for BERT model not compiling in FX #1539

Merged
merged 1 commit into from
Dec 8, 2022
Merged

fix: Change equals-check from reference to value for BERT model not compiling in FX #1539

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion py/torch_tensorrt/fx/converters/acc_ops_converters.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3369,7 +3369,7 @@ def acc_ops_gelu(
) -> Union[TRTTensor, Sequence[TRTTensor]]:
input_val = kwargs["input"]
approximate = kwargs["approximate"]
if approximate is not "none":
if approximate != "none":
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow good catch!

raise RuntimeError("GeLU converter currently doesn't support fast gelu compute")
if not isinstance(input_val, TRTTensor):
raise RuntimeError(
Expand Down