Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: aten::einsum schema switch for Torch 1.14 nightly #1420

Merged
merged 1 commit into from
Oct 28, 2022

Conversation

gs-olive
Copy link
Collaborator

Description

  • aten::einsum schema in 1.14 is aten::einsum(str equation, Tensor[] tensors, *, int[]? path=None) -> Tensor, whereas that of 1.13 has only the first two arguments
  • Updated test cases to use three arguments instead of two
  • Updated converter schema to allow for additional arguments
  • Fails 1.13 tests, as 1.14 schema is incompatible

Relevant to PR #1412

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
    • Will fail existing CI tests, as 1.14 schema is not compatible with 1.13 schema

Checklist:

  • [ x ] My code follows the style guidelines of this project (You can use the linters)
  • [ x ] I have performed a self-review of my own code
  • [ x ] I have commented my code, particularly in hard-to-understand areas and hacks
  • [ x ] I have made corresponding changes to the documentation
  • [ x ] I have added tests to verify my fix or my feature
  • [ x ] New and existing unit tests pass locally with my changes
  • [ x ] I have added the relevant labels to my PR in so that relevant reviewers are notified

@gs-olive gs-olive added the release: v1.4 Tagged to be included in v1.4 label Oct 25, 2022
@github-actions github-actions bot added component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: core Issues re: The core compiler component: tests Issues re: Tests labels Oct 25, 2022
@narendasan
Copy link
Collaborator

@gs-olive are you basing this branch on the 1.14 update branch?
This PR should be based on that branch and target that branch

@peri044
Copy link
Collaborator

peri044 commented Oct 27, 2022

@gs-olive Can you target your changes to update_master branch ? Here is the reference PR #1412. Once you push your changes to that branch, we can merge this PR #1412

@gs-olive gs-olive changed the base branch from master to update_master October 28, 2022 20:04
- `aten::einsum` schema in 1.14 is `aten::einsum(str equation, Tensor[]
tensors, *, int[]? path=None) -> Tensor`, whereas that of 1.13 has only
the first two arguments
- Updated test cases to use three arguments instead of two
- Updated converter schema to allow for additional arguments
- Fails 1.13 tests, as 1.14 schema is incompatible
@gs-olive
Copy link
Collaborator Author

gs-olive commented Oct 28, 2022

Updated the base branch target, and cleaned up intermediate commits so only this change gets merged in.

@gs-olive gs-olive marked this pull request as ready for review October 28, 2022 21:19
@peri044 peri044 merged commit e75123c into pytorch:update_master Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla signed component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: core Issues re: The core compiler component: tests Issues re: Tests release: v1.4 Tagged to be included in v1.4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants