Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add converter for aten::sign unary op #1391

Merged
merged 2 commits into from
Oct 5, 2022
Merged

feat: Add converter for aten::sign unary op #1391

merged 2 commits into from
Oct 5, 2022

Conversation

gs-olive
Copy link
Collaborator

@gs-olive gs-olive commented Oct 5, 2022

Description

This feature adds the sign unary converter

Fixes #1074

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • [ x ] My code follows the style guidelines of this project (You can use the linters)
  • [ x ] I have performed a self-review of my own code
  • [ x ] I have commented my code, particularly in hard-to-understand areas and hacks
  • [ x ] I have made corresponding changes to the documentation
  • [ x ] I have added tests to verify my fix or my feature
  • [ x ] New and existing unit tests pass locally with my changes
  • [ x ] I have added the relevant labels to my PR in so that relevant reviewers are notified

@gs-olive
feat: Add converter for sign unary operator
d94b449 
- Add sign operator
- Update test cases to test op
- Ensure tests cover both int and float cases with negative and positive
sign
- Ensure tests cover cases where elements equal zero
@gs-olive
Remove round unary from PR
0342c64
@github-actions github-actions bot added component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: core Issues re: The core compiler component: tests Issues re: Tests labels Oct 5, 2022
narendasan
narendasan approved these changes Oct 5, 2022
View reviewed changes
Copy link
Collaborator

@narendasan narendasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@narendasan narendasan marked this pull request as ready for review October 5, 2022 23:40
@narendasan narendasan merged commit 38dfa0c into pytorch:master Oct 5, 2022
@gs-olive gs-olive deleted the sign_converter branch October 6, 2022 00:06
gs-olive added a commit to gs-olive/TensorRT that referenced this pull request Oct 11, 2022
@gs-olive
feat: Add converter for aten::sign unary op (pytorch#1391)
bfeb194 
* feat: Add converter for sign unary operator

- Add sign operator
- Update test cases to test op
- Ensure tests cover both int and float cases with negative and positive
sign
- Ensure tests cover cases where elements equal zero

* Remove round unary from PR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@narendasan narendasan narendasan approved these changes

Assignees
No one assigned
Labels
cla signed component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: core Issues re: The core compiler component: tests Issues re: Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

↔ [Converter] Add support for aten::sign in Torch-TensorRT
3 participants
@gs-olive @narendasan @facebook-github-bot