Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update lower.py #1324

Merged
merged 1 commit into from
Aug 30, 2022
Merged

Update lower.py #1324

merged 1 commit into from
Aug 30, 2022

Conversation

frank-wei
Copy link
Contributor

@frank-wei frank-wei commented Aug 30, 2022

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

  1. Fixes a fstring issue.

Type of change

Please delete options that are not relevant and/or add your own.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

@frank-wei frank-wei merged commit e374eb1 into master Aug 30, 2022
frank-wei pushed a commit that referenced this pull request Aug 30, 2022
narendasan added a commit that referenced this pull request Sep 9, 2022
* chore: additional options for perf_run tool

Signed-off-by: dperi <dperi@nvidia.com>

* feat: Add fx2trt backend and revamp current perf utility to accept CLI arguments

Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>

* chore: Refactor fx2trt functionality

Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>

* chore: Fix fp16 functionality for fx2trt backend

Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>

* chore: refactor

Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>

* chore: minor change

Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>

* refactor: Refactor perf_run and add internal benchmark scripts

Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>

* chore : minor refactor

Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>

* chore: Apply precommit tooling

Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>

* chore: Fix data loader issues and nox file paths

Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>

* chore: rebase and minor changes

Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>

* chore: Fix reporting to a file setting

Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>

* Update lower.py (#1324)

* docs: [Automated] Regenerating documenation for e374eb1

Signed-off-by: Torch-TensorRT Github Bot <torch-tensorrt.github.bot@nvidia.com>

* refactor: Refactor testing to use cosine similarity, remove redundancy models and restructuring

Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>

* chore: move to cosine similarity comparison

Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>

* refactor: Refactor nox file testing

Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>

* chore: add missing scripts

Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>

* chore: Linter fixes

Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>

* fix!: Fixed Windows compilation failures

Signed-off-by: Anurag Dixit <a.dixit91@gmail.com>

* chore: Minor fix

Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>

* chore: use rn18 instead of rn50

Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>

* docs: [Automated] Regenerating documenation for a1a4786

Signed-off-by: Torch-TensorRT Github Bot <torch-tensorrt.github.bot@nvidia.com>

* chore: Add cpp tests with cosine sim

Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>

* chore: linter fixes

Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>

* [feat] Add support for argmax and argmin (#1312)

* [feat] Add support for argmax and argmin

Adds support for aten::argmax and aten::argmin.

Fixes # (issue)

Please delete options that are not relevant and/or add your own.

- Bug fix (non-breaking change which fixes an issue)
- New feature (non-breaking change which adds functionality)
- Breaking change (fix or feature that would cause existing functionality to not work as expected)
- This change requires a documentation update

- [ ] My code follows the style guidelines of this project (You can use the linters)
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas and hacks
- [ ] I have made corresponding changes to the documentation
- [ ] I have added tests to verify my fix or my feature
- [ ] New and existing unit tests pass locally with my changes
- [ ] I have added the relevant labels to my PR in so that relevant reviewers are notified

* move max.cpp tests to test_max.cpp no functional change

* fix permissions on max.cpp

* docs: [Automated] Regenerating documenation for 9db2852

Signed-off-by: Torch-TensorRT Github Bot <torch-tensorrt.github.bot@nvidia.com>

* chore: Deepcopy other objects

Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>

* fix: Fix deepcopy issues of PTQ calibrators

Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>

* chore: linter fixes

Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>

* chore: Adding a guideline to build on Windows platform (#1337)

* chore: Adding Windows build guideline

Signed-off-by: Anurag Dixit <a.dixit91@gmail.com>

* chore: Fix formatting

Signed-off-by: Anurag Dixit <a.dixit91@gmail.com>

Signed-off-by: Anurag Dixit <a.dixit91@gmail.com>

* docs: [Automated] Regenerating documenation for 00a1f03

Signed-off-by: Torch-TensorRT Github Bot <torch-tensorrt.github.bot@nvidia.com>

* chore: minor fixes

Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>

* chore: Linter fixes

Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>

* chore: Linter fixes

Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>

* docs: [Automated] Regenerating documenation for 1efe4b1

Signed-off-by: Torch-TensorRT Github Bot <torch-tensorrt.github.bot@nvidia.com>

* docs: [Automated] Regenerating documenation for 10b9ecd

Signed-off-by: Torch-TensorRT Github Bot <torch-tensorrt.github.bot@nvidia.com>

* add support for aten::reciprocal(int) (#1308)

* docs: [Automated] Regenerating documenation for 096fd41

Signed-off-by: Torch-TensorRT Github Bot <torch-tensorrt.github.bot@nvidia.com>

Signed-off-by: dperi <dperi@nvidia.com>
Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>
Signed-off-by: Torch-TensorRT Github Bot <torch-tensorrt.github.bot@nvidia.com>
Signed-off-by: Anurag Dixit <a.dixit91@gmail.com>
Co-authored-by: dperi <dperi@nvidia.com>
Co-authored-by: Dheeraj Peri <peri.dheeraj@gmail.com>
Co-authored-by: Wei <wwei6@fb.com>
Co-authored-by: Torch-TensorRT Github Bot <torch-tensorrt.github.bot@nvidia.com>
Co-authored-by: Anurag Dixit <a.dixit91@gmail.com>
Co-authored-by: Michael Feliz <104801882+mfeliz-cruise@users.noreply.github.com>
@frank-wei frank-wei deleted the frank-wei-patch-1 branch November 28, 2022 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants