Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Aligning bazel version for consistency across different docker… #1250

Merged
merged 1 commit into from
Aug 10, 2022

Conversation

andi4191
Copy link
Contributor

@andi4191 andi4191 commented Aug 10, 2022

…files and documentations

Signed-off-by: Anurag Dixit a.dixit91@gmail.com

Description

Bazel version has been bumped to 5.2.0.
Updating the Dockerfiles and README.md

Fixes # (issue)

Type of change

Please delete options that are not relevant and/or add your own.

  • Bug fix (non-breaking change which fixes an issue)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

…files and documentations

Signed-off-by: Anurag Dixit <a.dixit91@gmail.com>
@andi4191 andi4191 added documentation Improvements or additions to documentation channel: docker labels Aug 10, 2022
@andi4191 andi4191 requested a review from narendasan August 10, 2022 18:59
@narendasan
Copy link
Collaborator

These look fine, it would be great if we can consolidate these by reading .bazelrc or something

@andi4191
Copy link
Contributor Author

cc: @peri044 @apbose : Please update the same on DLFW side.

@narendasan: Yeah I will refactor it.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

@andi4191 andi4191 merged commit f814415 into master Aug 10, 2022
@andi4191 andi4191 deleted the anuragd/bump_bazel_version branch August 10, 2022 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
channel: docker cla signed documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants