Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Changed the hardcoded values to macros for DLA memory sizes #1247

Merged
merged 2 commits into from
Aug 10, 2022
Merged

refactor: Changed the hardcoded values to macros for DLA memory sizes #1247

merged 2 commits into from
Aug 10, 2022

Conversation

andi4191
Copy link
Contributor

@andi4191 andi4191 commented Aug 10, 2022 •
edited
Loading

Signed-off-by: Anurag Dixit a.dixit91@gmail.com

Description

Refactored the hard coded values to macro for DLA specific memory sizes

Fixes # (issue)

Type of change

Please delete options that are not relevant and/or add your own.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@github-actions github-actions bot added component: conversion Issues re: Conversion stage component: core Issues re: The core compiler labels Aug 10, 2022
@andi4191 andi4191 self-assigned this Aug 10, 2022
@andi4191 andi4191 requested a review from narendasan August 10, 2022 06:20
@andi4191 andi4191 changed the title refdctor: Changed the hardcoded values to macros for DLA memory sizes refactor: Changed the hardcoded values to macros for DLA memory sizes Aug 10, 2022
github-actions[bot]
github-actions bot approved these changes Aug 10, 2022
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

github-actions[bot]
github-actions bot approved these changes Aug 10, 2022
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

github-actions[bot]
github-actions bot approved these changes Aug 10, 2022
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

github-actions[bot]
github-actions bot approved these changes Aug 10, 2022
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

@andi4191
refdctor: Changed the hardcoded values to macros
5c646a3 
Signed-off-by: Anurag Dixit <a.dixit91@gmail.com>
@andi4191
chore: Moved macros to core/utils
ad7c081 
Signed-off-by: Anurag Dixit <a.dixit91@gmail.com>
@andi4191 andi4191 force-pushed the anuragd/remove_hard_codings branch from 97a6411 to ad7c081 Compare August 10, 2022 18:29
github-actions[bot]
github-actions bot approved these changes Aug 10, 2022
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

github-actions[bot]
github-actions bot approved these changes Aug 10, 2022
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

github-actions[bot]
github-actions bot approved these changes Aug 10, 2022
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

github-actions[bot]
github-actions bot approved these changes Aug 10, 2022
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

@andi4191 andi4191 requested a review from narendasan August 10, 2022 21:43
github-actions[bot]
github-actions bot approved these changes Aug 10, 2022
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

github-actions[bot]
github-actions bot approved these changes Aug 10, 2022
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

narendasan
narendasan approved these changes Aug 10, 2022
View reviewed changes
Copy link
Collaborator

@narendasan narendasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@narendasan narendasan merged commit c74b13e into master Aug 10, 2022
@andi4191 andi4191 deleted the anuragd/remove_hard_codings branch September 1, 2022 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@narendasan narendasan narendasan approved these changes

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees

@andi4191 andi4191

Labels
cla signed component: conversion Issues re: Conversion stage component: core Issues re: The core compiler
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andi4191 @narendasan @facebook-github-bot