Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FX] Sync enhancement done internally at Meta #1161

Merged
merged 1 commit into from
Jul 5, 2022
Merged

[FX] Sync enhancement done internally at Meta #1161

merged 1 commit into from
Jul 5, 2022

Conversation

yinghai
Copy link

@yinghai yinghai commented Jul 4, 2022 •
edited
Loading

91196dedd10ed4061bef719b01fe917192a6fc17 Shiyan Deng dsy842974287@fb.com fix EngineHolder
608acce060d91ac93099f59e6165d43ffd79d50a Shiyan Deng dsy842974287@fb.com delete unused file
f88cb1566ae1c72634668fa26fadc3ef368b9727 Alex Beloi alexbeloi@fb.com [fx] add common_subexpression_elimination graph opt
b079de89bce912c29284809722cae63cb185c481 Yinghai Lu yinghai@fb.com handle list of integers in SliceOp check
e8f8dbda72625872a2657cdfd09dd59209f98090 Shiyan Deng dsy842974287@fb.com Add a pass to eliminate unsqueeze + cat + getitem pattern
675b28120c432c63bf4d451a4479b2376f73201d Kefei Lu kefeilu@fb.com Back out "[fx] add common_subexpression_elimination graph opt"
a3fb38bb6193b86a0ef0795a9104c073f5044598 Shiyan Deng dsy842974287@fb.com Back out "Back out "[fx] add common_subexpression_elimination graph opt""
0ea2b5782d70ed07b2158a96a45082aba68c55f6 Andrew Or andrewor@fb.com [Quant][fx][bc-breaking] Replace is_reference with convert_to_reference
2e4384397e73e99a3d56303864dc09e23420dda1 Shreyansh Prajapati shreyanshp@fb.com Test dynamic shape suport for acc_ops.sigmoid
78f7505cbe18850f43261b5f92e67262127e229e Mor Tzur mortzur@fb.com uncomment accidentally commented out acc_op tests
a7c0210a5c6468d978fc55a541b08da4e1782df7 Shreyansh Prajapati shreyanshp@fb.com Test dynamic shape support for acc_ops.avgpool and error message change
8aab78b134c778bcafe56f0fd5baa9bf51d7fef9 Shreyansh Prajapati shreyanshp@fb.com Test dynamic shape support for acc_ops.any
0591b671542c186a257152f8ed82aecbd2322feb Shreyansh Prajapati shreyanshp@fb.com Test dynamic shape support for acc_ops.avgpool
5d36837498f72f5ad3432eecf3f4e4091ac23071 Shreyansh Prajapati shreyanshp@fb.com Test dynamic shape support for acc_ops.batchnorm
9a3134742872040b31a70bf216c81de5dcd82c45 Shreyansh Prajapati shreyanshp@fb.com Test dynamic shape support for acc_ops.binary_ops
4802100968d39418d6d1ce75c0407b3344e5cfd9 Shreyansh Prajapati shreyanshp@fb.com Test dynamic shape support for acc_ops.as_strided
6ccf77223a40e16d635d453b6342658bdc44062e Shreyansh Prajapati shreyanshp@fb.com Test dynamic shape support for acc_ops.cat
0dd29ac935705926cc29bf03f5da922d93adae17 Shreyansh Prajapati shreyanshp@fb.com Test dynamic shape support for acc_ops.chunk
81737ebcecb0a57a683971d9052b3f3262030d20 Shreyansh Prajapati shreyanshp@fb.com Added test case for testing dynamic shape support for acc_ops.clamp
0c2604c6db94309c8a76de00e8c69ce21d2114a8 Yinghai Lu yinghai@fb.com [fx2trt] Fix constant tensor conversion dtype bug

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant and/or add your own.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

Changes done internally at Facebook
d01d744 
91196dedd10ed4061bef719b01fe917192a6fc17 Shiyan Deng <dsy842974287@fb.com> fix EngineHolder
608acce060d91ac93099f59e6165d43ffd79d50a Shiyan Deng <dsy842974287@fb.com> delete unused file
f88cb1566ae1c72634668fa26fadc3ef368b9727 Alex Beloi <alexbeloi@fb.com> [fx] add common_subexpression_elimination graph opt
b079de89bce912c29284809722cae63cb185c481 Yinghai Lu <yinghai@fb.com> handle list of integers in SliceOp check
e8f8dbda72625872a2657cdfd09dd59209f98090 Shiyan Deng <dsy842974287@fb.com> Add a pass to eliminate unsqueeze + cat + getitem pattern
675b28120c432c63bf4d451a4479b2376f73201d Kefei Lu <kefeilu@fb.com> Back out "[fx] add common_subexpression_elimination graph opt"
a3fb38bb6193b86a0ef0795a9104c073f5044598 Shiyan Deng <dsy842974287@fb.com> Back out "Back out "[fx] add common_subexpression_elimination graph opt""
0ea2b5782d70ed07b2158a96a45082aba68c55f6 Andrew Or <andrewor@fb.com> [Quant][fx][bc-breaking] Replace is_reference with convert_to_reference
2e4384397e73e99a3d56303864dc09e23420dda1 Shreyansh Prajapati <shreyanshp@fb.com> Test dynamic shape suport for acc_ops.sigmoid
78f7505cbe18850f43261b5f92e67262127e229e Mor Tzur <mortzur@fb.com> uncomment accidentally commented out acc_op tests
a7c0210a5c6468d978fc55a541b08da4e1782df7 Shreyansh Prajapati <shreyanshp@fb.com> Test dynamic shape support for acc_ops.avgpool and error message change
8aab78b134c778bcafe56f0fd5baa9bf51d7fef9 Shreyansh Prajapati <shreyanshp@fb.com> Test dynamic shape support for acc_ops.any
0591b671542c186a257152f8ed82aecbd2322feb Shreyansh Prajapati <shreyanshp@fb.com> Test dynamic shape support for acc_ops.avgpool
5d36837498f72f5ad3432eecf3f4e4091ac23071 Shreyansh Prajapati <shreyanshp@fb.com> Test dynamic shape support for acc_ops.batchnorm
9a3134742872040b31a70bf216c81de5dcd82c45 Shreyansh Prajapati <shreyanshp@fb.com> Test dynamic shape support for acc_ops.binary_ops
4802100968d39418d6d1ce75c0407b3344e5cfd9 Shreyansh Prajapati <shreyanshp@fb.com> Test dynamic shape support for acc_ops.as_strided
6ccf77223a40e16d635d453b6342658bdc44062e Shreyansh Prajapati <shreyanshp@fb.com> Test dynamic shape support for acc_ops.cat
0dd29ac935705926cc29bf03f5da922d93adae17 Shreyansh Prajapati <shreyanshp@fb.com> Test dynamic shape support for acc_ops.chunk
81737ebcecb0a57a683971d9052b3f3262030d20 Shreyansh Prajapati <shreyanshp@fb.com> Added test case for testing dynamic shape support for acc_ops.clamp
0c2604c6db94309c8a76de00e8c69ce21d2114a8 Yinghai Lu <yinghai@fb.com> [fx2trt] Fix constant tensor conversion dtype bug
f0edd3db9b8f74103b536e1f2af81ce8558d2f88 Lu Fang <lufang@fb.com> [Not for landing] Unblock ifr_unified_1_with_cover_dhen's lowering
e610d365fa21f495d9b651e519ce8a407d3aa744 Lu Fang <lufang@fb.com> [Not for landing] Unblock ifr_unified_1_with_cover_dhen's lowering
eec55e9c3bab30dea9cde52feb9cc74f30a43035 Yinghai Lu <yinghai@fb.com> [fx2trt] Fix constant tensor conversion dtype bug
851ca556610bd396645a9822932939d12d6ed915 Yinghai Lu <yinghai@fb.com> [fx2trt] Fix constant tensor conversion dtype bug
@yinghai yinghai requested a review from frank-wei July 4, 2022 07:33
@yinghai yinghai changed the title Changes done internally at Facebook [FX] Sync enhancement done internally at Meta Jul 4, 2022
github-actions[bot]
github-actions bot approved these changes Jul 4, 2022
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

github-actions[bot]
github-actions bot approved these changes Jul 4, 2022
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

frank-wei
frank-wei approved these changes Jul 5, 2022
View reviewed changes
Copy link
Contributor

@frank-wei frank-wei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@frank-wei frank-wei merged commit 2717771 into master Jul 5, 2022
@yinghai
Copy link
Author

yinghai commented Jul 5, 2022

Wait. CircleCI failed. It seems that we need to install tabulate python package?

@frank-wei
Copy link
Contributor

yes, I noticed that. Fix in another PR #1163

@yinghai yinghai deleted the fb-sync-yinghai branch July 5, 2022 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frank-wei frank-wei frank-wei approved these changes

@github-actions github-actions[bot] github-actions[bot] approved these changes

@842974287 842974287 Awaiting requested review from 842974287

@narendasan narendasan Awaiting requested review from narendasan

@wushirong wushirong Awaiting requested review from wushirong

Assignees
No one assigned
Labels
cla signed component: api [Python] Issues re: Python API component: fx fx
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yinghai @frank-wei @facebook-github-bot