Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fx2trt] Modify lower setting class #1107

Merged
merged 9 commits into from
Jun 9, 2022
Merged

[fx2trt] Modify lower setting class #1107

merged 9 commits into from
Jun 9, 2022

Conversation

frank-wei
Copy link
Contributor

Description

Separate the LowerSettingBasic

Fixes # (issue)

Type of change

Please delete options that are not relevant and/or add your own.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

Wei Wei added 2 commits June 8, 2022 19:08
Changes done internally at Facebook
469d968 
364639a8ab2ee7531ce5259b8985a3c90bda4fdf Wei Wei <wwei6@fb.com> [fx2trt] target files added
07d8e842b54b9c727f4215239f6c007cc7a62c9f Wei Wei <wwei6@fb.com> Swap fx2trt_oss to torch_tensorrt
74731c90fd63e41ff5997887d8f72ca0b805cf8d Yinghai Lu <yinghai@fb.com> Fix uru_10x10 test
6c53d36a08a7d465a1108d7154ef29a373eb38cc Wei Wei <wwei6@fb.com> [fx2trt] Modify lower setting class to accommandate AIT lowering
50fa26d1b56888ec25eb839d4813bc695be20da9 wwei6 <wwei6@fb.com> [fx2trt] target files added
6e7f9b6c4f8afa32383c457e8133674640348810 wwei6 <wwei6@fb.com> fx2trt_oss change set1
cfe6089d8f49bbd96cc54f62148f0192d3f17ee9 wwei6 <wwei6@fb.com> Automatic update of fbcode/deeplearning/trt/torch_tensorrt to f9f010d
Merge branch 'master' into fb-sync-wwei6
9eb56c3
@github-actions github-actions bot added the component: api [Python] Issues re: Python API label Jun 9, 2022
@github-actions github-actions bot requested a review from narendasan June 9, 2022 02:53
github-actions[bot]
github-actions bot approved these changes Jun 9, 2022
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

Torch-TensorRT Github Bot and others added 7 commits June 8, 2022 19:58
docs: [Automated] Regenerating documenation for 8ad572d
816d859 
Signed-off-by: Torch-TensorRT Github Bot <torch-tensorrt.github.bot@nvidia.com>
@narendasan
Update pull_request_template.md
db5de0d 
Adding a task on contributors to add labels so PR reviewers will get notified to review
docs: [Automated] Regenerating documenation for 9621bc4
0cb7feb 
Signed-off-by: Torch-TensorRT Github Bot <torch-tensorrt.github.bot@nvidia.com>
Changes done internally at Facebook
a502b2d 
364639a8ab2ee7531ce5259b8985a3c90bda4fdf Wei Wei <wwei6@fb.com> [fx2trt] target files added
07d8e842b54b9c727f4215239f6c007cc7a62c9f Wei Wei <wwei6@fb.com> Swap fx2trt_oss to torch_tensorrt
docs: [Automated] Regenerating documenation for fa33de2
26cd366 
Signed-off-by: Torch-TensorRT Github Bot <torch-tensorrt.github.bot@nvidia.com>
Changes done internally at Facebook
81cd3c6 
6c53d36a08a7d465a1108d7154ef29a373eb38cc Wei Wei <wwei6@fb.com> [fx2trt] Modify lower setting class to accommandate AIT lowering
Merge branch 'fb-sync-wwei6' of https://github.com/pytorch/TensorRT i…
4df1d24 
…nto fb-sync-wwei6
@frank-wei frank-wei changed the title Fb sync wwei6 fx2trt] Modify lower setting class to accommandate AIT lowering Jun 9, 2022
@frank-wei frank-wei requested a review from yinghai June 9, 2022 03:05
@frank-wei frank-wei merged commit e4e02e1 into master Jun 9, 2022
@frank-wei frank-wei deleted the fb-sync-wwei6 branch June 9, 2022 03:06
@frank-wei frank-wei changed the title fx2trt] Modify lower setting class to accommandate AIT lowering [fx2trt] Modify lower setting class to accommandate AIT lowering Jun 9, 2022
github-actions[bot]
github-actions bot approved these changes Jun 9, 2022
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

github-actions[bot]
github-actions bot approved these changes Jun 9, 2022
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

@yinghai
Copy link

yinghai commented Jun 9, 2022

We should wait for a human accept before merge next time. Thanks.

@yinghai yinghai changed the title [fx2trt] Modify lower setting class to accommandate AIT lowering [fx2trt] Modify lower setting class Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

@narendasan narendasan Awaiting requested review from narendasan

@yinghai yinghai Awaiting requested review from yinghai

Assignees
No one assigned
Labels
cla signed component: api [Python] Issues re: Python API component: fx
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@frank-wei @yinghai @facebook-github-bot @narendasan