Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

finish #1808 cherry-pick, adjust interface #3627

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

coconutruben
Copy link
Contributor

Summary:

Why

  • some kernels were missed in the previous cherry-pick
  • the interface has changed slightly and extracting the intermediate_size is different

What

Differential Revision: D68792360

Summary:
# Why

- some kernels were missed in the previous cherry-pick
- the interface has changed slightly and extracting the `intermediate_size` is different

# What

- get remaining files from ROCm/composable_kernel@1ff50e7
- adjust interface
- explicitly pass silu as the activation function

Differential Revision: D68792360
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68792360

Copy link

netlify bot commented Jan 28, 2025

Deploy Preview for pytorch-fbgemm-docs ready!

Name Link
🔨 Latest commit 9d90119
🔍 Latest deploy log https://app.netlify.com/sites/pytorch-fbgemm-docs/deploys/6799542a92ca8500089cc435
😎 Deploy Preview https://deploy-preview-3627--pytorch-fbgemm-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants