Revert D51999938: Multisect successfully blamed "D51999938: Add early exit in sparse_async_cumsum ops" for otest failure #2208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… exit in sparse_async_cumsum ops" for otest failure Summary: This diff is reverting D51999938 D51999938: Add early exit in sparse_async_cumsum ops by meremeev has been identified to be causing the following test failure: Tests affected: - [deeplearning/fbgemm/fbgemm_gpu:sparse_ops_test - test_schema__test_asynchronous_complete_cumsum_2d (deeplearning.fbgemm.fbgemm_gpu.test.sparse_ops_test.SparseOpsTest)](https://www.internalfb.com/intern/test/562950068047718/) Here's the Multisect link: https://www.internalfb.com/multisect/3757962 Here are the tasks that are relevant to this breakage: We're generating a revert to back out the changes in this diff, please note the backout may land if someone accepts it. If you believe this diff has been generated in error you may Commandeer and Abandon it. Reviewed By: jasonjk-park Differential Revision: D52099677
✅ Deploy Preview for pytorch-fbgemm-docs canceled.
|
|
This pull request was exported from Phabricator. Differential Revision: D52099677 |
|
This pull request has been merged in af058b0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This diff is reverting D51999938
D51999938: Add early exit in sparse_async_cumsum ops by meremeev has been identified to be causing the following test failure:
Tests affected:
Here's the Multisect link:
https://www.internalfb.com/multisect/3757962
Here are the tasks that are relevant to this breakage:
We're generating a revert to back out the changes in this diff, please note the backout may land if someone accepts it.
If you believe this diff has been generated in error you may Commandeer and Abandon it.
Reviewed By: jasonjk-park
Differential Revision: D52099677