Improve the cron-job workflows #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ifconditions are meant to prevent that from happening. Tbh I'm not sure I understand why the current condition isn't working as expected -- but this PR changes the incantation to something closer to what we use in https://github.com/python/pyperformance/blob/main/.github/workflows/main.yml#L20 (which I know works).typing_extensions's tests for several of these jobs. This is because we're just runningpytestfor some of these jobs, and pytest is picking up the tests in thetest_typing_extensions.pyfile (becausetyping_extensionsis being cloned as a subdirectory for these jobs).