Fix protocol’s __init__ behaviour to be same like in python >= 3.8 #780
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello everyone, I am author of a dependency injection container for python: https://pypi.org/project/kink/. Lately we run into some issues with older versions of python were we do use
typing_extensions
as a pollyfill for missing functionalities.In python >= 3.8
_no_init
function which is responsible for disabling Protocol's initialisation is defined in the global scope of a module, which allows us to do checks like here: https://github.com/kodemore/kink/blob/master/kink/inject.py#L75. Sadly intyping_extensions
this function is defined as a local function so when doing the check memory address does not match and comparison fails. This is inconsistent with python >= 3.8 implementation and this PR fixes this inconsistency.I have also prepared test to cover the use-case.