In ctypes/__init__.pyi, RTLD_GLOBAL and RTLD_LOCAL are imported from _ctypes.pyi
#8657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! Unfortunately you were slightly too slow here — I filed #8656 just five minutes before you filed this. Sorry about that :) |
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
|
@AlexWaygood It was not a big change, so it was not a problem. |
Akuli
reviewed
Aug 31, 2022
| # TODO: import these from _ctypes once it no longer breaks pytype | ||
| RTLD_GLOBAL: int | ||
| RTLD_LOCAL: int | ||
| from _ctypes import RTLD_GLOBAL as RTLD_GLOBAL, RTLD_LOCAL as RTLD_LOCAL |
There was a problem hiding this comment.
I wonder why isort didn't move this import near the top of the file.
There was a problem hiding this comment.
Take a look at the second commit in #8656 — there's quite a few private stdlib modules that we have in typeshed that, by default, isort doesn't recognise as being part of the stdlib
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to google/pytype#1281 and google/pytype#1282, importing
RTLD_GLOBALandRTLD_LOCALfrom_ctypeswill not fail thepytypetest on CI if thepytype==2022.08.30version is specified.Other stuffs that should be defined in
_ctypeswill be migrated afterpytypestops using its own_ctypesstubs and starts usingtypeshed's_ctypesstubs.stdlib/_ctypes#8571, migrate some stuffs inctypes/__init__.pyiinto_ctypes.pyi, but circular import occurs #8633 and add and migrate constants fromctypes/__init__.pyito_ctypes.pyi#8643