Some PR comments, about comments

pyrightconfig.stricter.json

@@ -38,6 +38,7 @@
         "stubs/caldav",
         "stubs/commonmark",
         "stubs/cryptography",
+        "stubs/D3DShot",
         "stubs/dateparser",
         "stubs/dj-database-url",
         "stubs/docutils",
@@ -90,8 +91,7 @@
         "stubs/tzlocal/tzlocal/utils.pyi",
         "stubs/ttkthemes",
         "stubs/urllib3",
-        "stubs/vobject",
-        "stubs/D3DShot"
+        "stubs/vobject"
     ],
     "typeCheckingMode": "basic",
     "strictListInference": true,

stubs/D3DShot/METADATA.toml

@@ -2,4 +2,6 @@ version = "0.1.*"
 requires = ["types-Pillow"]
 
 [tool.stubtest]
+# The library only works on Windows; we currently only run stubtest on Ubuntu for third-party stubs in CI.
+# See #8660
 skip = true

stubs/D3DShot/d3dshot/capture_output.pyi

@@ -6,6 +6,7 @@ from typing_extensions import Literal, TypeAlias
 from PIL import Image
 
 _Frame: TypeAlias = Image.Image | Incomplete
+# FIXME: When #5768 is resolved:
 # _Frame: TypeAlias = Image.Image | npt.NDArray[np.int32] | npt.NDArray[np.float32] | _Tensor
 
 class CaptureOutputs(enum.Enum):

stubs/D3DShot/d3dshot/d3dshot.pyi

@@ -8,6 +8,7 @@ from d3dshot.display import Display as Display
 from PIL import Image
 
 _Frame: TypeAlias = Image.Image | Incomplete
+# FIXME: When #5768 is resolved:
 # _Frame: TypeAlias = Image.Image | npt.NDArray[np.int32] | npt.NDArray[np.float32] | _Tensor
 
 class Singleton(type):

stubs/D3DShot/d3dshot/display.pyi

@@ -6,6 +6,7 @@ from typing_extensions import Literal, TypeAlias
 from PIL import Image
 
 _Frame: TypeAlias = Image.Image | Incomplete
+# FIXME: When #5768 is resolved:
 # _Frame: TypeAlias = Image.Image | npt.NDArray[np.int32] | npt.NDArray[np.float32] | _Tensor
 
 class Display:

stubs/D3DShot/d3dshot/dll/d3d.pyi

@@ -1,6 +1,6 @@
 import sys
 from _typeshed import Incomplete
-from ctypes import Structure, _CArgObject, c_int32, c_uint, c_void_p
+from ctypes import Structure, _CArgObject, _CData, c_int32, c_uint, c_ulong, c_void_p
 from ctypes.wintypes import FLOAT, UINT
 from typing_extensions import TypeAlias
 
@@ -18,8 +18,11 @@ else:
 
 # TODO: Complete types once we can import non-types dependencies
 # See: https://github.com/python/typeshed/issues/5768
-# import comtypes
-_IUnknown: TypeAlias = Incomplete
+# from comtypes import IUnknown
+class _IUnknown:  # From comtypes.IUnknown
+    def QueryInterface(self, interface: type, iid: _CData | None = ...) -> _HRESULT: ...
+    def AddRef(self) -> c_ulong: ...
+    def Release(self) -> c_ulong: ...
 
 class DXGI_SAMPLE_DESC(Structure):
     Count: UINT

stubs/D3DShot/d3dshot/dll/dxgi.pyi

@@ -9,13 +9,16 @@ from d3dshot.dll.d3d import ID3D11Device
 from PIL import Image
 
 # TODO: Complete types once we can import non-types dependencies
-# See: https://github.com/python/typeshed/issues/5768
+# See: #5768
 # from torch import Tensor
-# import comtypes
+# from comtypes import IUnknown
 # import numpy.typing as npt
-# _IUnknown: TypeAlias = Incomplete
 _Frame: TypeAlias = Image.Image | Incomplete
 # _Frame: TypeAlias = Image.Image | npt.NDArray[np.int32] | npt.NDArray[np.float32] | Tensor
+class _IUnknown:  # From comtypes.IUnknown
+    def QueryInterface(self, interface: type, iid: _CData | None = ...) -> _HRESULT: ...
+    def AddRef(self) -> c_ulong: ...
+    def Release(self) -> c_ulong: ...
 
 # mypy does not support os.name checks, while pyright does https://github.com/python/mypy/issues/13002
 # import os
@@ -27,11 +30,6 @@ if sys.platform == "win32":
 else:
     _HRESULT: TypeAlias = Incomplete
 
-class _IUnknown:  # From comtypes.IUnknown
-    def QueryInterface(self, interface: type, iid: _CData | None = ...) -> _HRESULT: ...
-    def AddRef(self) -> c_ulong: ...
-    def Release(self) -> c_ulong: ...
-
 class _DXGIOutputPosition(TypedDict):
     left: LONG
     top: LONG