Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add _ctypes.pyi #8582

Merged
merged 7 commits into from
Aug 23, 2022
Merged

add _ctypes.pyi #8582

merged 7 commits into from
Aug 23, 2022

Conversation

junkmd
Copy link
Contributor

@junkmd junkmd commented Aug 21, 2022

see #8571

@github-actions

This comment has been minimized.

Sign in to view
hauntsaninja
hauntsaninja reviewed Aug 21, 2022
View reviewed changes
stdlib/_ctypes.pyi Outdated Show resolved Hide resolved
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
1 similar comment
@github-actions

This comment has been minimized.

Sign in to view
hauntsaninja
hauntsaninja reviewed Aug 21, 2022
View reviewed changes
stdlib/_ctypes.pyi Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@junkmd
Copy link
Contributor Author

junkmd commented Aug 21, 2022

@hauntsaninja
Thank you for the code correction.

Currently, all tests are passed.

Is there anything else I should do?

@AlexWaygood AlexWaygood linked an issue Aug 21, 2022 that may be closed by this pull request
Add stdlib/_ctypes #8571
Closed
@AlexWaygood AlexWaygood self-requested a review August 21, 2022 07:48
AlexWaygood
AlexWaygood reviewed Aug 21, 2022
View reviewed changes
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know little about ctypes, but this all looks good as far as I can see. Can confirm that COMError takes exactly three arguments on my Windows machine, and _COMError_Details looks good from all the examples I can find online!

@junkmd junkmd requested a review from hauntsaninja August 23, 2022 02:17
@hauntsaninja hauntsaninja merged commit 2066b95 into python:master Aug 23, 2022
@sobolevn sobolevn mentioned this pull request Aug 23, 2022
Merged
@junkmd junkmd deleted the _ctypes_in_stdlib branch August 23, 2022 23:47
This was referenced Aug 24, 2022
Closed
Merged
Closed
@junkmd junkmd mentioned this pull request Nov 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexWaygood AlexWaygood AlexWaygood left review comments

@hauntsaninja hauntsaninja hauntsaninja approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add stdlib/_ctypes
3 participants
@junkmd @hauntsaninja @AlexWaygood