Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_csv._Writer
is a confusing name for a protocol, given that there's also_csv._writer
and_csv.writer
. It's exactly the same as_typeshed.SupportsWrite[str]
, so we may as well just use that.strict
field of a_csv.Dialect
object is documented as being abool
, not anint
: https://docs.python.org/3/library/csv.html#csv.Dialect.strict_QuotingType
should really be a union of literal types: the runtime raises an exception if we pass in anything that's notQUOTE_ALL
,QUOTE_MINIMAL
,QUOTE_NONE
orQUOTE_NONNUMERIC
. It's probably unwise to use a union of literals here right now due to Temporary moratorium on literal constants (until the end of 2022) #7258, but we should use a type alias to indicate thatint
isn't really the correct type here._csv._reader.dialect
and_csv._writer.dialect
are read-only properties at runtime.