Accept mtime=None in linecache.cache entries.
#7623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexWaygood
reviewed
Apr 14, 2022
stdlib/linecache.pyi
Outdated
| @@ -7,7 +7,7 @@ else: | |||
| __all__ = ["getline", "clearcache", "checkcache"] | |||
|
|
|||
| _ModuleGlobals = dict[str, Any] | |||
| _ModuleMetadata = tuple[int, float, list[str], str] | |||
| _ModuleMetadata = tuple[int, float, list[str] | None, str] | |||
There was a problem hiding this comment.
Isn't mtime the second item in the tuple, rather than the third item?
https://github.com/python/cpython/blob/3.10/Lib/linecache.py#L68
There was a problem hiding this comment.
Oops, you're right. Fixed.
This comment has been minimized.
This comment has been minimized.
The mtime in linecache entries can be set to `None` fir files loaded via a `__loader__` (cf: https://github.com/python/cpython/blob/3.10/Lib/linecache.py#L70)
AlexWaygood
approved these changes
Apr 14, 2022
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mtime in linecache entries can be set to
Nonefir files loaded via a__loader__(cf: https://github.com/python/cpython/blob/3.10/Lib/linecache.py#L70)