Adding datetimerange stubs #3845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srittau
requested changes
Mar 17, 2020
| import datetime | ||
| from dateutil.relativedelta import relativedelta | ||
|
|
||
| class DateTimeRange: |
There was a problem hiding this comment.
Since this stub is for Python 2 as well, this should use object as base class to mark this as a new-style class:
class DateTimeRange(object):
Comment on lines
7
to
10
| start_time_format: str = ... | ||
| end_time_format: str = ... | ||
| is_output_elapse: bool = ... | ||
| separator: str = ... |
| end_time_format: str = ... | ||
| is_output_elapse: bool = ... | ||
| separator: str = ... | ||
| def __init__(self, start_datetime: Optional[str], end_datetime: Optional[str], start_time_format: str = ..., end_time_format: str = ...) -> None: ... |
There was a problem hiding this comment.
start_datetime and end_datetime have default values, so = ... is missing. (Optional is unfortunately slightly misnamed and does not indicate optional arguments.)
Comment on lines
32
to
33
| def set_start_datetime(self, value: Union[datetime.datetime, str], timezone: str = ...) -> None: ... | ||
| def set_end_datetime(self, value: Union[datetime.datetime, str], timezone: str = ...) -> None: ... |
There was a problem hiding this comment.
Since the timezone arguments default to None, they should have Optional[str] as arguments since they obviously accept None as well.
|
Thank you for that! Knew I was going to make some mistakes. I made those changes and pushed just now |
srittau
approved these changes
Mar 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello I was looking to use mypy and made stubs for a library that I was using. The library in question is this one https://github.com/thombashi/DateTimeRange . This is my first PR to typeshed so lmk if I missed anything!