Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move stubs for 'click' into 2and3 folder #1364

Merged
merged 1 commit into from
Jun 2, 2017

Conversation

Michael0x2a
Copy link
Contributor

@Michael0x2a Michael0x2a commented May 28, 2017

The "click" 3rd party library is currently listed as being Python 3.6+ only on typeshed.

The exact Python versions click supports is apparently unclear, but it definitely includes Python 2.7 and recent versions of Python 3, so moving it into the 2and3 folder is probably best.

@ambv
Copy link
Contributor

ambv commented Jun 2, 2017

Originally they were put in 3.6 because mypy didn't accept variable annotations for 3.5 and older stubs, and we wanted to test if those actually work. So moving to 3/ is not a big deal at all.

Moving to 2and3 is maybe going to give you problems with strings because I just used "str" everywhere.

So, I'm okay with the change but beware that you're likely going to have some cleaning up to do.

@ambv ambv merged commit d25c5b9 into python:master Jun 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants