-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
requests: Use the Any
trick in HTTPError
#11207
Merged
hauntsaninja
merged 7 commits into
python:main
from
Akuli:requests-http-error-any-trick
Dec 30, 2023
Merged
requests: Use the Any
trick in HTTPError
#11207
hauntsaninja
merged 7 commits into
python:main
from
Akuli:requests-http-error-any-trick
Dec 30, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This reverts commit 5fbf9fa.
The mypy_primer output isn't really comparable to the previous PR, because people have already added redundant casts and
Also, mypy doesn't warn about unnecessary checks or casts: an |
Diff from mypy_primer, showing the effect of this PR on open source code: cloud-init (https://github.com/canonical/cloud-init)
- cloudinit/url_helper.py:343: error: Item "None" of "Response | None" has no attribute "status_code" [union-attr]
- cloudinit/url_helper.py:344: error: Item "None" of "Response | None" has no attribute "headers" [union-attr]
|
hauntsaninja
approved these changes
Dec 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #10875 for context.
Usually, when you get a
HTTPError
, the response will be set. Specifically, it will always be set when the requests library raises the error.But people also use
HTTPError
as a generic "just show this generic error message" exception that doesn't include any details about what happened. For example, paasta_tools/mesos_maintenance.py has plenty of code like this (as pointed out by mypy_primer):I think we should get the best of both worlds with the
Any
trick.