Update mypy-protobuf #10914
Merged
Update mypy-protobuf #10914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @nipunn1313 |
This comment has been minimized.
This comment has been minimized.
|
How about the |
Don't have time to figure this out right now, sorry. |
Should the |
This comment has been minimized.
This comment has been minimized.
|
@Avasam I get this locally now when running the TF script: Do you know what's up with that? I indeed can't find a |
This comment has been minimized.
This comment has been minimized.
Not sure, I just ran it fresh locally and it seems to be just fine |
any.proto is similar to standard library protobuf file (or maybe like protobuf-dev in analogy to python-dev). It's not part of tensorflow. It's sign that your protobuf install includes compiler, but not protobuf related headers. Fix is something like One option to make the script more robust is maybe to instead use |
Avasam
reviewed
Oct 19, 2023
| tensorflow/compiler/xla/xla_pb2.pyi | ||
| tensorflow/core/util/example_proto_fast_parsing_test_pb2.pyi | ||
|
|
||
| isort "$REPO_ROOT/stubs/tensorflow/tensorflow" |
There was a problem hiding this comment.
If #10912 is merged first, this becomes:
Suggested change
| isort "$REPO_ROOT/stubs/tensorflow/tensorflow" | |
| ruff check "$REPO_ROOT/stubs/tensorflow/tensorflow" --fix-only |
|
lgtm |
AlexWaygood
reviewed
Oct 19, 2023
Avasam
approved these changes
Oct 20, 2023
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #10909 (comment)
I had to edit some
sedcommands so they worked for me on Linux.The script also set the version of
stubs/protobuf/METADATA.tomlto 4.21.0; I changed it back.I tried updating
PROTOBUF_VERSIONandPYTHON_PROTOBUF_VERSIONto the latest (24.4/4.24.4), but the script failed; apparently they no longer distribute the Python library in the way the script expects.