-
-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-115582 and gh-115545: Windows release build mixes up free-threaded files #98
Conversation
This straightens out the builds, and also simplifies a few things now that we run so many configurations. I've tested that the correct packages are all created for unsigned builds. Need to run a signed build to make sure nothing else goes wrong, but otherwise this should fix everything except that nogil extensions won't have the right |
@ambv I don't know if you're interested in reviewing this, but it should be ready to go. It's the way I should've done the freethreaded builds in the first place - as separate configurations. Luckily, thanks to the parallelism, the overall build doesn't take much longer. |
I read through this but ultimately it's a lot of YAML changes that look good to me but I'm not confident about judging either way. So to observe the changes I started build #151696 from this PR branch on the current cpython |
Hm, signing binaries failed across the board here even though I did approve it. |
I'll check my Azure settings. I updated that key vault to the newer permissions model, so maybe it didn't stick properly? |
Looks like it didn't stick :) I restarted the signing jobs |
Those tasks are just internal publishes. The actual checkbox impacts the entire Publish stage, so you'll see as soon as it starts running whether there's a chance it'll go public (this one won't). |
Well done finding the one combination of build options I missed 😆 |
That's why they pay me the big bucks haha |
I started another one to see it go to completion. |
You'll be able to grab the built files from the Artifacts page to try them out if you want. |
@ambv Are you happy enough with the changes? |
Yeah, thanks! I went to Czechia and back over the weekend, so I didn't have access to a Windows box to test the installers. I assume they work :) |
They work at least as well as in the last alpha 😆 |
No description provided.