Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable netlify #2912

Closed
wants to merge 2 commits into from
Closed

enable netlify #2912

wants to merge 2 commits into from

Conversation

ewdurbin
Copy link
Member

@ewdurbin ewdurbin commented Dec 6, 2022

No description provided.

@ewdurbin ewdurbin requested review from AA-Turner and a team as code owners December 6, 2022 13:46
@netlify
Copy link

netlify bot commented Dec 6, 2022

Deploy Preview for python-peps-preview failed.

Name Link
🔨 Latest commit 166e224
🔍 Latest deploy log https://app.netlify.com/sites/python-peps-preview/deploys/638f4b98cccd010009205aba

Unverified

This user has not yet uploaded their public signing key.
@ewdurbin
Copy link
Member Author

ewdurbin commented Dec 6, 2022

Not sure what's up... seems it might be an incompatibility with python3.8 (best available on netlify)

@AA-Turner
Copy link
Member

I don't think PEPs need Netlify, as we already have render previews. Is there a reference to the discussion for this at all?

A

@ewdurbin
Copy link
Member Author

ewdurbin commented Dec 6, 2022

wires crossed here, I read that as CAM asking for netlify here #2875 (review)

@ewdurbin ewdurbin closed this Dec 6, 2022
@ewdurbin ewdurbin deleted the netlify branch December 6, 2022 14:19
@AA-Turner
Copy link
Member

No worries, thank you--good that the CPython previews are now enabled.

A

@CAM-Gerlach
Copy link
Member

Sorry for the confusion, and thanks for taking care of that—it will be a huge benefit there to both PR authors and reviewers alike!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants