Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the requirement for Resolution to be the final header #2678

Merged
merged 2 commits into from
Jun 29, 2022
Merged

Remove the requirement for Resolution to be the final header #2678

merged 2 commits into from
Jun 29, 2022

Conversation

pradyunsg
Copy link
Member

See #2673 for an example of where this existing description was insufficient.

CAM-Gerlach
CAM-Gerlach requested changes Jun 28, 2022
View reviewed changes
Copy link
Member

@CAM-Gerlach CAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO, its better to just drop the check for it being at the end, since it isn't really that necessary, as opposed to making the description more complicated and increasing the min terminal width substantially.

@pradyunsg @CAM-Gerlach
Remove the requirement for Resolution to be the final header
02c5633 
Co-authored-by: CAM Gerlach <CAM.Gerlach@Gerlach.CAM>
@pradyunsg pradyunsg changed the title Add a better description to the Resolution lint check Remove the requirement for Resolution to be the final header Jun 29, 2022
@pradyunsg
Copy link
Member Author

pradyunsg commented Jun 29, 2022 •
edited
Loading

Please squash-merge this, if this gets merged.

@CAM-Gerlach CAM-Gerlach added the lint Linter-related work and linting fixes on PEPs label Jun 29, 2022
@CAM-Gerlach
Copy link
Member

Please squash-merge this, if this gets merged.

That's the only option we have enabled 😄

CAM-Gerlach
CAM-Gerlach approved these changes Jun 29, 2022
View reviewed changes
Copy link
Member

@CAM-Gerlach CAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @pradyunsg !

@CAM-Gerlach CAM-Gerlach merged commit 34e9a8d into python:main Jun 29, 2022
@pradyunsg pradyunsg deleted the better-resolution-lint-check-description branch June 29, 2022 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

@CAM-Gerlach CAM-Gerlach CAM-Gerlach approved these changes

@hugovk hugovk Awaiting requested review from hugovk hugovk is a code owner

Assignees
No one assigned
Labels
lint Linter-related work and linting fixes on PEPs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pradyunsg @CAM-Gerlach @JelleZijlstra