Look at arguments when generating constraints for an overload #8845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This improves a lot of cases. I'm not totally sure why we skipped the arguments in the past.
ilevkivskyi
approved these changes
May 19, 2020
| @@ -486,12 +486,11 @@ def infer_against_overloaded(self, overloaded: Overloaded, | |||
| template: CallableType) -> List[Constraint]: | |||
| # Create constraints by matching an overloaded type against a template. | |||
| # This is tricky to do in general. We cheat by only matching against | |||
| # the first overload item, and by only matching the return type. This | |||
| # the first overload item that is callable compatible. This | |||
There was a problem hiding this comment.
This comment is 8 years old. I think this answers your question in the PR description.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves a lot of cases. I'm not totally sure why we skipped the
arguments in the past.