Fix error reporting context for missing generic type arguments #7100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I wasn't able to fully test this out internally because I ran into some other issues but one thing I noticed is this makes aliases like |
msullivan
reviewed
Jun 28, 2019
| @@ -2369,7 +2369,9 @@ def check_and_set_up_type_alias(self, s: AssignmentStmt) -> bool: | |||
| # so we need to replace it with non-explicit Anys. | |||
| res = make_any_non_explicit(res) | |||
| no_args = isinstance(res, Instance) and not res.args | |||
| fix_instance_types(res, self.fail) | |||
| fix_instance_types(res, self.fail, | |||
There was a problem hiding this comment.
I think this needs to be done conditionally only when no_args, maybe?
There was a problem hiding this comment.
Yes, aliases like A = List should be allowed even with the flag, will fix it now.
|
@msullivan I fixed the errors you reported, could you please try again? |
msullivan
approved these changes
Jul 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7077
The logic of the fix is quite straightforward: emit the error immediately when we fix an instance type, and not in a traversal after the main pass. Note that I fix this only for the new analyser, because the old one will be anyway deprecated soon.
This causes a bit of code churn because we need to pass the flags to several functions, but the logic should not change much. I didn't add many new tests, since we have a bunch of existing tests. It would probably make sense to play with this, suggestions for more tests are very welcome.