Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix whole-file # type: ignore comments. #6853

Merged
merged 1 commit into from
May 20, 2019
Merged

Fix whole-file # type: ignore comments. #6853

merged 1 commit into from
May 20, 2019

Conversation

brandtbucher
Copy link
Member

Fixes #6852, and adds a regression test.

gvanrossum
gvanrossum approved these changes May 20, 2019
View reviewed changes
Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix!

@gvanrossum gvanrossum merged commit 728bbfd into python:master May 20, 2019
PattenR pushed a commit to PattenR/mypy that referenced this pull request Jun 23, 2019
@brandtbucher @PattenR
Fix whole-file ignoring. (python#6853)
5fba61a 
Fixes python#6852, and adds a regression test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Whole file # type: ignore does not silence import errors
2 participants
@brandtbucher @gvanrossum