Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add object self-type to tuple test fixture #18592

Merged
merged 1 commit into from
Feb 3, 2025

Conversation

ilevkivskyi
Copy link
Member

@ilevkivskyi ilevkivskyi commented Feb 3, 2025

This makes it more similar to the real typeshed. It is needed to reproduce tricky failures in tests, e.g. #18585. If this causes slower tests, some tests may be switched to tuple-simple.pyi.

@JukkaL JukkaL merged commit 02f9a70 into python:master Feb 3, 2025
12 checks passed
@ilevkivskyi ilevkivskyi deleted the make-tuple-real branch February 3, 2025 15:06
wesleywright pushed a commit that referenced this pull request Feb 4, 2025
This makes it more similar to the real typeshed. It is needed to
reproduce tricky failures in tests, e.g.
#18585. If this causes slower tests,
some tests may be switched to `tuple-simple.pyi`.
@wesleywright wesleywright mentioned this pull request Feb 4, 2025
5 tasks
wesleywright pushed a commit that referenced this pull request Feb 4, 2025
This makes it more similar to the real typeshed. It is needed to
reproduce tricky failures in tests, e.g.
#18585. If this causes slower tests,
some tests may be switched to `tuple-simple.pyi`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants