Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent crash on generic NamedTuple with unresolved typevar bound #18585

Merged
merged 6 commits into from
Feb 3, 2025
+34 −2
Merged

Prevent crash on generic NamedTuple with unresolved typevar bound #18585

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
fc2ab45
Prevent crash on generic NamedTuple with unresolved typevar bound
sterliakov Feb 2, 2025
87cf7d5
Move partial_fallback higher up inheritance chain
sterliakov Feb 2, 2025
c2c8c35
Silence "need type annotation" from fallback
sterliakov Feb 2, 2025
85f78ec
improve test
hauntsaninja Feb 3, 2025
2462bf0
Merge remote-tracking branch 'upstream/master' into bugfix/st-crash-n…
sterliakov Feb 3, 2025
6119136
Add a testcase
sterliakov Feb 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions mypy/semanal_shared.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -364,6 +364,9 @@ class HasPlaceholders(BoolTypeQuery):
def __init__(self) -> None:
super().__init__(ANY_STRATEGY)

def visit_tuple_type(self, t: TupleType, /) -> bool:
return super().visit_tuple_type(t) or t.partial_fallback.accept(self)

def visit_placeholder_type(self, t: PlaceholderType) -> bool:
return True

Expand Down