Fix getargs argument passing #18350
Merged
Fix getargs argument passing #18350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdce8p
suggested changes
Dec 28, 2024
There was a problem hiding this comment.
Thanks for bisecting the issue @hauntsaninja! Seems I missed that in #17930. Left one small comment, LGTM otherwise.
cdce8p
reviewed
Dec 28, 2024
Co-authored-by: Marc Mueller <30130371+cdce8p@users.noreply.github.com>
|
Oh good suggestions, thanks for the review! I also looked over the CPython getargs code and made some cosmetic changes to make this look more like that |
cdce8p
reviewed
Dec 28, 2024
svalentin
pushed a commit
that referenced
this pull request
Dec 30, 2024
Fixes mypyc/mypyc#1078 Introduced in #17930 See the first commit to see the bug (wrong condition) --------- Co-authored-by: Marc Mueller <30130371+cdce8p@users.noreply.github.com>
hauntsaninja
added a commit
to hauntsaninja/mypy
that referenced
this pull request
Dec 31, 2024
Improves test added in python#18350 to confirm the args are actually parsed correctly
hauntsaninja
added a commit
that referenced
this pull request
Dec 31, 2024
Improves test added in #18350 to confirm the args are actually parsed correctly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes mypyc/mypyc#1078
Introduced in #17930
See the first commit to see the bug (wrong condition)