Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix junit writing bug introduced in #16388 #16417

Merged
merged 1 commit into from
Nov 7, 2023
Merged

Fix junit writing bug introduced in #16388 #16417

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix junit writing bug introduced in #16388
  • Loading branch information
@mrwright
mrwright committed Nov 6, 2023

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
commit 48e62fc64b08c2bc0d4dfb33237ea8806f087787
7 changes: 6 additions & 1 deletion mypy/main.py
View file
Original file line number Diff line number Diff line change
@@ -1504,7 +1504,12 @@ def maybe_write_junit_xml(
py_version = f"{options.python_version[0]}_{options.python_version[1]}"
if options.junit_format == "global":
util.write_junit_xml(
td, serious, {None: all_messages}, options.junit_xml, py_version, options.platform
td,
serious,
{None: all_messages} if all_messages else {},
options.junit_xml,
py_version,
options.platform,
)
else:
# per_file
7 changes: 6 additions & 1 deletion mypyc/build.py
View file
Original file line number Diff line number Diff line change
@@ -106,7 +106,12 @@ def emit_messages(options: Options, messages: list[str], dt: float, serious: boo
if options.junit_xml:
py_version = f"{options.python_version[0]}_{options.python_version[1]}"
write_junit_xml(
dt, serious, {None: messages}, options.junit_xml, py_version, options.platform
dt,
serious,
{None: messages} if messages else {},
options.junit_xml,
py_version,
options.platform,
)
if messages:
print("\n".join(messages))