-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix spurious errors on builtins.open #15161
Conversation
Diff from mypy_primer, showing the effect of this PR on open source code: vision (https://github.com/pytorch/vision) got 1.19x slower (34.1s -> 40.7s)
|
Any way to test this? (preferably in a way that clarifies the value and isn't a regression test for #14796) |
I tested manually... I think it's a little hard to write a test, like with #14088 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I verified manually that this fixes the errors. Thanks!
I think this change may have introduced a regression. If I run mypy on typeshed's stdlib stubs, it now reports that The specific commands I ran were:
The results of the last command are:
These errors cannot be reproduced if I run typeshed's |
This reverts commit 66602fc.
Fixes #14796