[mypyc] Add LoadAddress primitive op for PySet_Type & PyFrozenSet_Type #13057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bfc6715 to
7811f08
Compare
This also fixes mypyc/mypyc#917 RE above, the root issue is that mypyc didn't know builtins.set was a built-in name, so it guessed it comes from the module globals. This didn't blow up anything up somehow... until the dataclasses commit[^1] which made the `__annotations__` logic for dataclasses try to better preserve the type annotations (previously they would be erased to builtins.type). This new logic would use `load_type` to load `builtins.set` (so it can be put in `__annotations__`) which went poorly as only types registered with `load_address_op` are considered built-ins. [^1]: python@1bcfc04
7811f08 to
e6882c3
Compare
It's good enough and I can't be bothered to work support in for AbstractSet in the full test suite.
JelleZijlstra
approved these changes
Jul 3, 2022
Gobot1234
pushed a commit
to Gobot1234/mypy
that referenced
this pull request
Aug 12, 2022
python#13057) This also fixes mypyc/mypyc#917 RE above, the root issue is that mypyc didn't know builtins.set was a built-in name, so it guessed it comes from the module globals. This didn't blow up anything up somehow... until the dataclasses commit[^1] which made the `__annotations__` logic for dataclasses try to better preserve the type annotations (previously they would be erased to builtins.type). This new logic would use `load_type` to load `builtins.set` (so it can be put in `__annotations__`) which went poorly as only types registered with `load_address_op` are considered built-ins. [^1]: python@1bcfc04
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This also fixes mypyc/mypyc#917.
RE above, the root issue is that mypyc didn't know builtins.set was a built-in name, so it guessed it comes from the module globals. This didn't blow up anything up somehow... until the dataclasses commit (1bcfc04) which made the
__annotations__logic for dataclasses try to better preserve the type annotations (previously they would be erased to builtins.type). This new logic would useload_typeto loadbuiltins.set(so it can be put in__annotations__) which went poorly as only types registered withload_address_opare considered built-ins.Test Plan
I added a run test sub-case that tests a generic built-in type (i.e.
set) is stored correctly in the dataclass'__annotations__.